Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes-client 8.3.7 breaks binary upload #209

Closed
lholmquist opened this issue Apr 13, 2020 · 5 comments
Closed

Kubernetes-client 8.3.7 breaks binary upload #209

lholmquist opened this issue Apr 13, 2020 · 5 comments

Comments

@lholmquist
Copy link
Member

No description provided.

@lholmquist
Copy link
Member Author

I did a little more investigating and it looks like the issue happens after the [email protected] was added.

@lholmquist
Copy link
Member Author

i did some more testing and it seems the error starts happening when the swagger-client moved from the merge-deep module to the deepmerge module

I created a little test project that simulates the merges, and the subsequent stream check that request does:

https://github.com/lholmquist/merge-deep-merge-fu

@lholmquist
Copy link
Member Author

For reference, the place where things fail in request, https://github.com/request/request/blob/3c0cddc7c8eb60b470e9519da85896ed7ee0081e/request.js#L441

@lholmquist lholmquist mentioned this issue Apr 17, 2020
Merged
@lholmquist lholmquist mentioned this issue May 5, 2020
Merged
@lholmquist
Copy link
Member Author

It looks like the [email protected] will now pull in the updated swagger-fluent module, #212, we could upgrade to that or wait until snyk sends the PR for 9.0.0

@lholmquist
Copy link
Member Author

just merged #234 which updates to the 9.0.0 kubernetes-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lholmquist