Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE issue with transitive dependency tough-cookie #382

Closed
dShringi opened this issue Sep 7, 2023 · 3 comments
Closed

CVE issue with transitive dependency tough-cookie #382

dShringi opened this issue Sep 7, 2023 · 3 comments

Comments

@dShringi
Copy link

dShringi commented Sep 7, 2023

Hi, the dependency used in the project i.e. kubernetes-client has a transitive depedency over tough-cookie which has a major vulnerability CVE-2023-26136 below version 4.1.3. Could you please help with the mitigation for the same.

@mhdawson
Copy link
Contributor

@lholmquist can you take a look at this

@lholmquist
Copy link
Member

👀

@lholmquist
Copy link
Member

So it looks like the request module makes use of the affected tough-cookie module(https://github.com/salesforce/tough-cookie), but when the request module creates an instance of the CookieJar, it does not allow other options to be passed in, so the mode that the CVE says is affected can't be updated to the malicious setting.

Even better is that the openshift-rest-client doesn't pass any options that far down the code chain, so that code is never touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants