Node process exits regardless of open socket

[phra]

hi, i am doing some tests with your library but my node process always quits after around 10 seconds.

source code:

var raw = require ("raw-socket");

var socket = raw.createSocket ({protocol: raw.Protocol.ICMP});

socket.on ("message", function (buffer, source) {
    console.log ("received " + buffer.length + " bytes from " + source);
});

i would expect it to remain alive, as stated in the readme, but for some reason, it just exists after a short time.

tested with node v12.20.0

[stephenwvickers]

This works for me...

[phra]

thanks for the reply. have you tried with node v12.20.0 ?

[stephenwvickers]

I thought I did, but it looks like no. I will try again with v12.

[stephenwvickers]

Sure enough, using 12.22.1, after about 8 seconds it exits:

[stephen@dev-centos7 tmp]$ sudo node app.js
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
received 84 bytes from 8.8.8.8
[stephen@dev-centos7 tmp]$

I will take a look.

[algj]

I have tried v14.15.4 on my server, it quits in a second, but for some reason it does not in REPL and it works as expected. Very weird.

Tested on local machine with v15.5.1 and it works.

I upgraded to v15.5.1 on my server and had tons of errors when installing with npm i raw-socket related to compiling (I can upload those errors if needed).

I downgraded node.js to v10.23.1 on my server and it seems to work without any problem.

[phra]

it could be a regression in node itself. maybe is it worth it to open an issue on https://github.com/nodejs/node

[algj]

I reproduced the problem on machine.

I tested 12 ICMP requests and instantly sent back the reply, it would just close without any error.
I also tested just receiving 25 ICMP requests, it would close down when 25th request was received and processed in node.js.
After printing out the 25th request data, node.js would exit instantly after it.

Using Linux, node.js v15.5.1

[algj]

There's something very weird going on:
Using icmp library (which uses node-raw-socket) it reads exactly 68 requests:

const icmp = require('icmp')
let i = 0;
icmp.listen(()=>console.log(++i));

With my other code I could read exactly 79 requests, not more and not less.

I tested it like 5 times each, how quickly pings come doesn't make any difference when it would close.

It seems over REPL it works correctly (sometimes):
Works very well (tested 4000 requests):

$ node
const icmp = require('icmp'); let i = 0; icmp.listen(()=>console.log(++i));

$ sudo ping 127.0.0.1 -f

But this seems to be not working (only 80 received requests):

$ node
require('./index.js');

/* index.js
const icmp = require('icmp'); let i = 0; icmp.listen(()=>console.log(++i));
*/

If you put setInterval in your script, it won't exit, but it will stop receiving requests.

I tried NOT outputting anything, it did help quite a bit (over 300 requests without closing) but it did not fix the problem.

It might be some V8 optimization...

[algj]

This is a possible memory leak if opened a lot of times, but I guess no one's doing that?
At least it works.

    // quick fix for #70 issue
    var gcFix = setInterval(()=>this.wrap, 2147483647).unref();
    this.wrap.on('close', ()=>{clearInterval(gcFix));

This is one horrifying fix which at least works.

[phra]

i would suggest writing a minimized example that shows different behaviors across some node versions and then opening an issue on https://github.com/nodejs/node to report the potential regression.

[algj]

i would suggest writing a minimized example that shows different behaviors across some node versions and then opening an issue on https://github.com/nodejs/node to report the potential regression.

My best guess is that it's the raw.cc (raw.node) which has a problem.

I guess other way to solve this problem is putting it in an array/object.

This fix is better than having a non-working code.