Skip to content

[BUG] ERESOLVE overriding peer dependency in 11.2.0 and newer #8688

@Artur-

Description

@Artur-

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

Given package.json

{
  "name": "no-name",
  "license": "UNLICENSED",
  "type": "module",
  "dependencies": {
    "@vaadin/react-components": "24.9.2",
    "@vaadin/react-components-pro": "24.9.2"
  },
  "overrides": {
    "@vaadin/react-components": "$@vaadin/react-components",
    "@vaadin/react-components-pro": "$@vaadin/react-components-pro"
  }
}

Running npx -y [email protected] install results in

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @vaadin/[email protected]
npm warn Found: @types/[email protected]
npm warn node_modules/@types/react
npm warn   peer @types/react@"17 || 18 || 19" from @lit/[email protected]
npm warn   node_modules/@lit/react
npm warn     @lit/react@"^1.0.7" from @vaadin/[email protected]
npm warn     node_modules/@vaadin/react-components
npm warn   1 more (@vaadin/react-components)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional @types/react@"^18.2.37 || ^19" from @vaadin/[email protected]
npm warn node_modules/@vaadin/react-components-pro
npm warn   @vaadin/react-components-pro@"24.9.2" from the root project
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @vaadin/[email protected]
npm warn Found: [email protected]
npm warn node_modules/react-dom
npm warn   peer react-dom@"^18.2.0 || ^19" from @vaadin/[email protected]
npm warn   node_modules/@vaadin/react-components
npm warn     @vaadin/react-components@"24.9.2" from the root project
npm warn     1 more (@vaadin/react-components-pro)
npm warn
npm warn Could not resolve dependency:
npm warn peer react-dom@"^18.2.0 || ^19" from @vaadin/[email protected]
npm warn node_modules/@vaadin/react-components-pro
npm warn   @vaadin/react-components-pro@"24.9.2" from the root project

and npx -y [email protected] ls --all

npm error code ELSPROBLEMS
npm error invalid: @lit/[email protected] /Users/artur/test/npm-error/node_modules/@lit/react
npm error invalid: @types/[email protected] /Users/artur/test/npm-error/node_modules/@types/react
npm error invalid: [email protected] /Users/artur/test/npm-error/node_modules/react-dom
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/a11y-base
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/button
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/checkbox
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/component-base
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/confirm-dialog
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/dialog
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/form-layout
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/grid
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/lit-renderer
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/overlay
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/select
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/text-field
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/tooltip
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-lumo-styles
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-material-styles
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/vaadin-themable-mixin
npm error invalid: @polymer/[email protected] /Users/artur/test/npm-error/node_modules/@polymer/polymer
npm error invalid: [email protected] /Users/artur/test/npm-error/node_modules/lit
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/field-base
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/input-container
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/item
npm error invalid: @vaadin/[email protected] /Users/artur/test/npm-error/node_modules/@vaadin/list-box

Expected Behavior

npx -y [email protected] install

results in no errors

npx -y [email protected] ls --all

results in no errors

Steps To Reproduce

As above

Environment

  • npm: 11.2+, including the not yet released 11.6.3
  • Node.js: 24.9.0
  • OS Name: mac os

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bugthing that needs fixingNeeds Triageneeds review for next steps

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions