Skip to content

Commit d3ecffe

Browse files
authored
feat(vite): add ajv dev dependency for vite-plugin-dts (#31107)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Currently, when we generate a vite library that uses `vite-plugin-dts` it breaks the project graph and all nx commands fail. It happens because the wrong version of `ajv` is being hoisted in `node_modules/ajv` so the expected module path required from `vite-plugin-dts` is not found. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Nx commands should work out of the box when we generate a library with vite. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent 3873fee commit d3ecffe

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/vite/.eslintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
// we only check if the package is installed
4545
"eslint",
4646
// we ensure it is installed and only use it when eslint is installed
47-
"@nx/eslint"
47+
"@nx/eslint",
48+
"ajv"
4849
]
4950
}
5051
]

packages/vite/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
"@nx/js": "file:../js",
3838
"picomatch": "4.0.2",
3939
"tsconfig-paths": "^4.1.2",
40-
"semver": "^7.6.3"
40+
"semver": "^7.6.3",
41+
"ajv": "^8.0.0"
4142
},
4243
"peerDependencies": {
4344
"vite": "^5.0.0 || ^6.0.0",

0 commit comments

Comments
 (0)