Skip to content

With @nx/rspack:rspack executor, the project is not type checked even when skipTypeChecking set to false #31026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 4 tasks
dpnolte opened this issue May 3, 2025 · 0 comments · May be fixed by #31027
Open
1 of 4 tasks

Comments

@dpnolte
Copy link

dpnolte commented May 3, 2025

Current Behavior

  1. Create a project that uses @nx/rspack:rspack as build target with SkipTypeChecking set to false.
  2. Run build target for project
  3. Type check has not been run

Expected Behavior

The type check should run.

GitHub Repo

https://github.com/dpnolte/nx-rspack-type-checking

Steps to Reproduce

  1. Go to packages/rspack-lib/src/lib/rspack-lib.ts to spot the obvious typescript type error.
  2. Run the build target using @nx/rspack:rspack executor: nx build rspack-lib
  3. No type error is shown in the terminal and build succeeds.

Note, it does error if I change https://github.com/nrwl/nx/blob/master/packages/rspack/src/executors/rspack/rspack.impl.ts#L33-L35 into:

    if (!normalizedOptions.skipTypeChecking) {
        await executeTypeCheck(normalizedOptions, context);
    }

Nx Report

Node           : 22.14.0
OS             : darwin-arm64
Native Target  : aarch64-macos
pnpm           : 10.10.0

nx (global)  : 20.7.2
nx           : 20.8.1
@nx/js       : 20.8.1
@nx/rspack   : 20.8.1
typescript   : 5.7.3
---------------------------------------
Registered Plugins:
@nx/js/typescript
@nx/js/typescript
@nx/rspack/plugin
---------------------------------------
Cache Usage: 0.00 B / 92.64 GB

Failure Logs

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant