Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup error handling code for Accept #1483

Closed
andrewvo148 opened this issue Mar 30, 2024 · 2 comments
Closed

chore: cleanup error handling code for Accept #1483

andrewvo148 opened this issue Mar 30, 2024 · 2 comments
Labels
chore help wanted

Comments

@andrewvo148
Copy link

https://github.com/nsqio/nsq/blob/2127c0a1ce50a66d61d78496033b15ef5cb5e250/internal/protocol/tcp_server.go#L27C4-L35C5
@mreiferson
Copy link
Member

Yea, we can probably clean this up now that there's a better standard API, feel free to submit a PR!

@mreiferson mreiferson changed the title Refactoring the code to check for errors when invoking 'Accept'. It should use 'errors.Is(err, net.ErrClosed)'. chore: cleanup error handling code for Accept Apr 28, 2024
@likid1412 likid1412 mentioned this issue Oct 25, 2024
Merged
@mreiferson
Copy link
Member

fixed in #1500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mreiferson @andrewvo148