Skip to content

Breaks production build after [email protected] #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryoppippi opened this issue Oct 5, 2024 · 4 comments
Open

Breaks production build after [email protected] #6

ryoppippi opened this issue Oct 5, 2024 · 4 comments

Comments

@ryoppippi
Copy link

Related issue: sveltejs/svelte#13510

I'll create a reproduction later

@ntsd
Copy link
Owner

ntsd commented Oct 8, 2024

It's working fine from what I tested with the scratch project with the latest Svelte 5 version.
Btw could you share your rendered HTML file?
Maybe some of the attributes are removed by the 'html-minifier-terser`.
You could also disable the config https://github.com/terser/html-minifier-terser#options-quick-reference.

Also, there are defaults here that could break the HTML attributes

minifierOptions: {

@sotasan
Copy link

sotasan commented Oct 24, 2024

That sounds like you're removing whitespace and/or comments via the minifier, which Svelte is sensitive to. Try turning those parts off.

Originally posted by @dummdidumm in sveltejs/svelte#13510 (comment)

@sotasan
Copy link

sotasan commented Oct 24, 2024

That sounds like you're removing whitespace and/or comments via the minifier, which Svelte is sensitive to. Try turning those parts off.

Originally posted by @dummdidumm in sveltejs/svelte#13510 (comment)

For me it was collapseWhitespace.

@ntsd
Copy link
Owner

ntsd commented Oct 25, 2024

It seems many people have this issue, so I decided to remove the collapse whitespace by default.

It will fixed by v1.0.4

#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants