Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

Clarify whether writes to window.location.href are correct #6

Open
vsund opened this issue Mar 16, 2018 · 0 comments
Open

Clarify whether writes to window.location.href are correct #6

vsund opened this issue Mar 16, 2018 · 0 comments
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work
Milestone
Feature-complete ...

Comments

@vsund
Copy link
Member

vsund commented Mar 16, 2018

There were some writes to window.location in the code. tsc said that it's an read-only property, so I changed these to window.location.href in 4ee243a.

Is writing the redirect URI to window.location.href what we want here?
@vsund vsund mentioned this issue Mar 16, 2018
Open
26 tasks
@vsund vsund added area/port Item concerns the port from blockstack.js size/small Item requires not much work labels Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/port Item concerns the port from blockstack.js size/small Item requires not much work
Projects
None yet
Milestone
Feature-complete to blockstack.js v0....
Development

No branches or pull requests
1 participant
@vsund