File postions in boss/logex/fmpsee limited to 31 bits

[wehimwich]

The variables that handle file positions in fmpsee/ library routines fmpsetpos() and fmpposition() are int but should be long instead. They were changed in the bulk unlongify of c9cbc93 and never changed back.

Fortunately, this is benign as long as the files are less than 2³¹ bytes long. Since boss only uses file positions for .snp and .prc files, this is unlikely to create a problem, even on 64-bit systems. It seems likely that this breaks at least some parts of logex; It also seems likely that no one uses it anymore (let us know if you do). These reasons, and the amount of work to fix the calling FORTRAN, probably made this clean-up a low priority task. In fact, switching to int variables could be viewed as a win in the short-term. That may have been the actual decision at the time, but if it was (things were busy), I don't remember it. Anyway, the same limitation existed in the previous 32-bit only FS versions.

In boss, the FORTRAN generally has the affected variables declared integer*4. To extend the range for 64-bit systems, these variables will probably need to be changed into two element arrays. Some of these values are also stored in other integer arrays. Some adjustment will be needed for that. It seem unlikely any of these variables (or array elements) are used in arithmetic but that should be checked for carefully as well.

In logex, at least some of the involved variables are declared integer*2, so it seems likely that some commands, probably at least plot, won't work, even on 32-bit systems. It seems unlikely anyone is still using logex, but it may not take much work to clean this up.

In the same commit, the line number variables in the fmpsetline() routine were also changed to int. Whether .snp files with 2³¹ or more lines need to be supported is a different question. If so, it would have ramifications in the line number handling in boss as well. This appears to be an issue for logex for processing .log files.

Pieces needed to support larger .snp and .prc files:

• Fix fmpsetpos() and fmpposition()
• Expand size of affected FORTRAN variables
• Accommodate larger variables when stored in FORTRAN arrays
• Check for arithmetic with FORTRAN file positions variables/arrays

Line numbers in .skd files:

• Consider/fix how many lines should be allowed in .snp files (fmpsetline() and more generally in boss).

logex:

• Consider fixing logex

[dehorsley]

Good catch. I think some of these incorrect ints could be caught by the compiler (with -Wconversion I think), but I seem to remember there was too many false positives.