Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logger implementation #14

Open
CromFr opened this issue Sep 13, 2021 · 1 comment
Open

Improve logger implementation #14

CromFr opened this issue Sep 13, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@CromFr
Copy link
Member

CromFr commented Sep 13, 2021

The current logger implementation is very basic: it just appends lines to a txt file.

Features to implement:

  • Log file rotation (to prevents huge log files)
  • Improve logger configuration:
    • Set file open mode: append (a) or overwrite on startup (w)
    • Set log verbosity (already implemented)
    • Configure log rotation (max size, retention duration)

Ideally there should be a "global log config" in nwnx.ini, that can be overridden by plugin-specific config files

@CromFr CromFr added the enhancement New feature or request label Sep 13, 2021
@scottmunday84
Copy link
Contributor

Maybe we're ready for Boost libs? There's a lot of great enhancements available to the library and it works well for Modern C++. It also has a great logging framework with rotation, mode, and verbosity handlers (defer to BOOST our current logic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants