Request constructor doesn't work with plain Node IncomingMessage

[p-bakker]

It seems the Request constructor expects to get passed in a enhanced version of the Node's IncomingRequest class, for example one from Express of Koa.

The problem lies in the fact that the plain IncomingMessage object doesn't have a query property, which the Request constructor bombs out on.

I'd say the Request constructor should work with plain IncominMessage instances and perform the enhancement/upgrade itself if not already done

[maxtruxa]

The best solution would probably be to create a wrapper package à la express-oauth-server for plain http.Servers. That wrapper would be responsible to preprocess http.IncomingMessage to be compatible with Request's constructor.
Can't think of a good name though.. node-oauth-server is too similar to this package's name and IIRC was previously used for this package on npm; http-oauth-server is ambiguous; maybe plain-oauth-server.

[p-bakker]

Why not just check inside this package if the argument that gets passed into the Request constructor has the query property and if not either add it of internally wrap it with something that adds the query property?

for example something like this:
if (request.query === undefined) {
request = Object.create(request, {
bar: {
get: function() { return QS.parse(parsedUrl.query) }
}
})
}

It just adds the qs module used by Express as a dependancy to this package

Adding a complete wrapper package seems a bit overkill to me and as you already concluded, differentiating between that wrapper and this package is difficult and most likely will confuse users

[mjsalinger]

@p-bakker I'm fine with that idea if you want to submit a PR for it...