Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendored notty fails on OCaml 5.4 #11481

Closed
Leonidas-from-XIV opened this issue Feb 14, 2025 · 2 comments
Closed

Vendored notty fails on OCaml 5.4 #11481

Leonidas-from-XIV opened this issue Feb 14, 2025 · 2 comments

Comments

@Leonidas-from-XIV
Copy link
Collaborator

Expected Behavior

The CI succeeds

Actual Behavior

The CI fails

Reproduction

Since ocaml/ocaml#13570 was merged, the tests on OCaml 5.4 trunk are failing:

 File "vendor/notty/src/notty.ml", lines 387-397, characters 43-7:
Error: Some record fields are undefined: out_width

Specifications

  • Version of dune (output of dune --version): main
  • Version of ocaml (output of ocamlc --version): 5.4+trunk
  • Operating system (distribution and version): any
@Leonidas-from-XIV
Copy link
Collaborator Author

PR with a fix in our vendored notty here: ocaml-dune/notty#10

@Leonidas-from-XIV Leonidas-from-XIV mentioned this issue Feb 14, 2025
Open
@Leonidas-from-XIV
Copy link
Collaborator Author

Fixed by #11482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Leonidas-from-XIV