Future-proof custom module interface

Author: odlp

README.md

@@ -114,7 +114,7 @@ bundle exec rake admin:special
 
 ```ruby
 class ObscureClassNameTask do
-  include OopsARake::Task.with_name("custom_name")
+  include OopsARake::Task.with_options(name: "custom_name")
 
   def call
     puts "Hello"

lib/oops_a_rake/task.rb

@@ -7,13 +7,13 @@ def self.included(klass)
       Registry::register(klass)
     end
 
-    def self.with_name(custom_task_name)
-      module_name = "#{custom_task_name.gsub(":", "_").classify}ClassMethods"
+    def self.with_options(name:)
+      module_name = "#{name.gsub(":", "_").classify}ClassMethods"
       mod = const_set(module_name, Module.new)
 
       mod.define_singleton_method(:included) do |klass|
-        klass.extend(OopsARake::Task::ClassMethods)
-        klass.define_singleton_method(:task_name) { custom_task_name }
+        klass.define_singleton_method(:task_name) { name }
+        klass.extend(ClassMethods)
         Registry::register(klass)
       end
 
@@ -22,7 +22,11 @@ def self.with_name(custom_task_name)
 
     module ClassMethods
       def task_name
-        name.underscore.gsub("/", ":").delete_suffix("_task")
+        if defined?(super)
+          super
+        else
+          name.underscore.gsub("/", ":").delete_suffix("_task")
+        end
       end
 
       def description(description)

spec/lib/oops_a_rake/task_spec.rb

@@ -92,10 +92,10 @@ def call
     expect(Rake::Task["well_documented"].comment).to eq("Informative")
   end
 
-  describe "custom task name" do
+  describe "::with_options" do
     it "allows tasks to specify a custom name" do
       define_class("ObscureClassNameTask") do
-        include OopsARake::Task.with_name("clear_name")
+        include OopsARake::Task.with_options(name: "clear_name")
 
         def call
           puts "Hello"
@@ -108,7 +108,7 @@ def call
 
     it "provides access to the task name from the class" do
       define_class("ObscureClassNameTask") do
-        include OopsARake::Task.with_name("custom_name")
+        include OopsARake::Task.with_options(name: "custom_name")
 
         def call
         end
@@ -119,7 +119,7 @@ def call
 
     it "names the module" do
       define_class("ObscureClassNameTask") do
-        include OopsARake::Task.with_name("foo:bar_baz")
+        include OopsARake::Task.with_options(name: "foo:bar_baz")
 
         def call
         end