Merge pull request #12 from odoo/master-safe-update-info-tso

ThanhDodeurOdoo · web-flow · commit adebdf70edae · 2024-08-26T07:04:18.000+02:00
[IMP] guard client bus calls
diff --git a/src/client.js b/src/client.js
@@ -224,8 +224,7 @@ export class SfuClient extends EventTarget {
      * @param {boolean} [param0.needRefresh] true if the server should refresh the local info from all sessions of this channel
      */
     updateInfo(info, { needRefresh } = {}) {
-        this._info = info;
-        this._bus.send(
+        this._bus?.send(
             {
                 name: CLIENT_MESSAGE.INFO_CHANGE,
                 payload: { info, needRefresh },
@@ -266,7 +265,7 @@ export class SfuClient extends EventTarget {
         if (!hasChanged) {
             return;
         }
-        this._bus.send(
+        this._bus?.send(
             {
                 name: CLIENT_MESSAGE.CONSUMPTION_CHANGE,
                 payload: { sessionId, states },

Original file line number	Diff line number	Diff line change
`@@ -224,8 +224,7 @@ export class SfuClient extends EventTarget {`
`224`	`224`	`* @param {boolean} [param0.needRefresh] true if the server should refresh the local info from all sessions of this channel`
`225`	`225`	`*/`
`226`	`226`	`updateInfo(info, { needRefresh } = {}) {`
`227`		`- this._info = info;`
`228`		`- this._bus.send(`
	`227`	`+ this._bus?.send(`
`229`	`228`	`{`
`230`	`229`	`name: CLIENT_MESSAGE.INFO_CHANGE,`
`231`	`230`	`payload: { info, needRefresh },`
`@@ -266,7 +265,7 @@ export class SfuClient extends EventTarget {`
`266`	`265`	`if (!hasChanged) {`
`267`	`266`	`return;`
`268`	`267`	`}`
`269`		`- this._bus.send(`
	`268`	`+ this._bus?.send(`
`270`	`269`	`{`
`271`	`270`	`name: CLIENT_MESSAGE.CONSUMPTION_CHANGE,`
`272`	`271`	`payload: { sessionId, states },`