-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "nominal_value" of Flow #991
Comments
I occasionally find it confusing; using the name nominal_value seems less intuitive. It might make more sense to name it nominal_capacity as you suggested, providing a clearer indication of its meaning. I agree with your suggestion to rename both to nominal_capacity. _ |
I still have to keep explaining people what the |
I agree that |
I guess that users that do not consciously distinct power and energy will stumble upon the different time index at some point. In my opinion, the new introductions (#1141) should be very distinct here. Also, the new result processing (cf. #1138) might make the difference clearer by not using these different types of data with the same index (that they in fact do not share). |
For
Flow
, we have the keywordnominal_value
. I think, the capacity of aFlow
(e.g. a power line) is actually easier to interpret as the "nominal value". Actually, I have been asked that quite some times. If we have anominal_capacity
of aFlow
, it would be arguable why it'snominal_storage_capacity
for theGenericStorage
. So we need to say eithernominal_flow_capacity
which is actually redundant. In my opinion, it makes sense to call bothnominal_capacity
.In fact, they are quite similar. In particular, they both accept a number (fixed capacity) or an Investment object.
The text was updated successfully, but these errors were encountered: