Skip to content

Commit 8ce4743

Browse files
author
Piotr Kiełkowicz
committed
github.com/fatih/hclfmt was archived. Technically there is a possibility to fork (or used another forked version) to executle hclfmt.
But it leads to another issues - problems with importing https://github.com/hashicorp/hcl/hcl/printers. HCL was released in version 2 so that the file structure was changes. I do not see any way to install it in changed Makefile. Go installs does not support pining to given tags so that always the newest version is installed. For now, the impact on build process should be minimal. it is used only in ./tools/lint/lint() method. I was able to execute it locally without executing hclfmt.
1 parent 6d95f31 commit 8ce4743

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

backend/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ RUN go clean -i net && \
2121
github.com/fzipp/gocyclo \
2222
golang.org/x/lint/golint \
2323
github.com/kisielk/errcheck \
24-
github.com/fatih/hclfmt \
2524
github.com/mjibson/esc \
2625
github.com/client9/misspell/cmd/misspell && \
2726
chmod a+wr --recursive /usr/local/go && \

tools/build/golang/Dockerfile

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ RUN go clean -i net && \
2828
RUN go get -tags netgo \
2929
github.com/FiloSottile/gvt \
3030
github.com/client9/misspell/cmd/misspell \
31-
github.com/fatih/hclfmt \
3231
github.com/fzipp/gocyclo \
3332
github.com/gogo/protobuf/gogoproto \
3433
github.com/gogo/protobuf/protoc-gen-gogoslick \

0 commit comments

Comments
 (0)