[TASK] Remove public access feature for registration lists (#4277)

oliverklee · web-flow · commit 212976a76005 · 2025-03-25T22:32:43.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -110,6 +110,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 
 ### Removed
 
+- Remove public access feature for registration lists (#4277)
 - Drop `Venue.zip` (#4274)
 - Drop `Venue.country` (#4273, #4275)
 - Drop `Event.language` (#4271)
diff --git a/Classes/Configuration/ListViewConfigurationCheck.php b/Classes/Configuration/ListViewConfigurationCheck.php
@@ -146,7 +146,7 @@ private function checkAccessToFrontEndRegistrationLists(): void
             'This value specifies who is able to see the registered persons an event in the front end .
             If this value is incorrect, persons may access the registration lists although they should not be allowed to
             (or vice versa).',
-            ['attendees_and_managers', 'login', 'world']
+            ['attendees_and_managers', 'login']
         );
     }
 
diff --git a/Classes/OldModel/LegacyEvent.php b/Classes/OldModel/LegacyEvent.php
@@ -1812,7 +1812,7 @@ public function isUserVip(int $userUid): bool
      * @param int<0, max> $registrationsVipListPID
      *        the value of the registrationsVipListPID parameter
      *        (only relevant for (seminar_list|my_events|my_vip_events))
-     * @param 'attendees_and_managers'|'login'|'world' $accessLevel
+     * @param 'attendees_and_managers'|'login' $accessLevel
      *
      * @return bool TRUE if a FE user is logged in and the user may view
      *                 the registrations list or may see a link to that
@@ -1829,13 +1829,6 @@ public function canViewRegistrationsList(
         }
 
         switch ($accessLevel) {
-            case 'world':
-                $result = $this->canViewRegistrationsListForWorldAccess(
-                    $whichPlugin,
-                    $registrationsListPID,
-                    $registrationsVipListPID
-                );
-                break;
             case 'login':
                 $result = $this->canViewRegistrationsListForLoginAccess(
                     $whichPlugin,
@@ -1967,63 +1960,14 @@ protected function canViewRegistrationsListForLoginAccess(
         return $result;
     }
 
-    /**
-     * Checks whether a FE user is logged in and whether he/she may view this
-     * seminar's registrations list or see a link to it.
-     *
-     * This function assumes that the access level for FE registration lists is
-     * "world".
-     *
-     * @param 'seminar_list'|'my_events'|'my_vip_events'|'list_registrations'|'list_vip_registrations' $whichPlugin
-     * @param int<0, max> $registrationsListPID
-     *        the value of the registrationsListPID parameter
-     *        (only relevant for (seminar_list|my_events|my_vip_events))
-     * @param int<0, max> $registrationsVipListPID
-     *        the value of the registrationsVipListPID parameter
-     *        (only relevant for (seminar_list|my_events|my_vip_events))
-     *
-     * @return bool TRUE if a FE user is logged in and the user may view
-     *                 the registrations list or may see a link to that
-     *                 page, FALSE otherwise
-     */
-    protected function canViewRegistrationsListForWorldAccess(
-        string $whichPlugin,
-        int $registrationsListPID = 0,
-        int $registrationsVipListPID = 0
-    ): bool {
-        $currentUserUid = GeneralUtility::makeInstance(Context::class)->getPropertyFromAspect('frontend.user', 'id');
-        \assert(\is_int($currentUserUid) && $currentUserUid >= 0);
-        $isLoggedIn = $currentUserUid > 0;
-
-        $hasListPid = $registrationsListPID > 0;
-        $hasVipListPid = $registrationsVipListPID > 0;
-
-        switch ($whichPlugin) {
-            case 'my_vip_events':
-                $result = $isLoggedIn && $this->isUserVip($currentUserUid)
-                    && $hasVipListPid;
-                break;
-            case 'list_vip_registrations':
-                $result = $isLoggedIn && $this->isUserVip($currentUserUid);
-                break;
-            case 'list_registrations':
-                $result = true;
-                break;
-            default:
-                $result = $hasListPid;
-        }
-
-        return $result;
-    }
-
     /**
      * Checks whether a FE user is logged in and whether he/she may view this
      * seminar's registrations list.
      * This function is intended to be used from the registrations list,
      * NOT to check whether a link to that list should be shown.
      *
      * @param 'seminar_list'|'my_events'|'my_vip_events'|'list_registrations'|'list_vip_registrations' $whichPlugin
-     * @param 'attendees_and_managers'|'login'|'world' $accessLevel
+     * @param 'attendees_and_managers'|'login' $accessLevel
      *
      * @return string an empty string if everything is OK, a localized error
      *                message otherwise
@@ -2035,9 +1979,6 @@ public function canViewRegistrationsListMessage(
         if (!$this->needsRegistration()) {
             return $this->translate('message_noRegistrationNecessary');
         }
-        if ($accessLevel === 'world') {
-            return '';
-        }
         if (!GeneralUtility::makeInstance(Context::class)->getAspect('frontend.user')->isLoggedIn()) {
             return $this->translate('message_notLoggedIn');
         }
diff --git a/Configuration/TypoScript/FrontEnd.typoscript b/Configuration/TypoScript/FrontEnd.typoscript
@@ -74,7 +74,7 @@ plugin.tx_seminars_pi1 {
   generalPriceInSingle = 0
 
   # who is allowed to view the list of registrations on the front end:
-  # "attendees_and_managers", "login" or "world"
+  # "attendees_and_managers" or "login"
   accessToFrontEndRegistrationLists = attendees_and_managers
 
   # whether detailed information for the speakers is shown in the single view
diff --git a/Documentation/Reference/SetupForTheSeminarManagerFront-endPlug-inInPlugintxSeminarsPi1/Index.rst b/Documentation/Reference/SetupForTheSeminarManagerFront-endPlug-inInPlugintxSeminarsPi1/Index.rst
@@ -397,7 +397,7 @@ override the corresponding value from TS Setup.**
 
    Description
          who is allowed to view the list of registrations on the front end;
-         allowed values are: attendees\_and\_managers, login, world
+         allowed values are: attendees\_and\_managers, login
 
    Default
          attendees\_and\_managers
diff --git a/Tests/LegacyFunctional/OldModel/LegacyEventTest.php b/Tests/LegacyFunctional/OldModel/LegacyEventTest.php
@@ -6611,206 +6611,6 @@ public function canViewRegistrationsListWithNeedsRegistrationAndLoginAccess(
         );
     }
 
-    /**
-     * Data provider for testing the canViewRegistrationsList function
-     * with world access.
-     *
-     * @return mixed[][] test data for canViewRegistrationsList with each row
-     *               having the following elements:
-     *               [expected] boolean: expected value (TRUE or FALSE)
-     *               [loggedIn] boolean: whether a user is logged in
-     *               [isRegistered] boolean: whether the logged-in user is
-     *                              registered for that event
-     *               [isVip] boolean: whether the logged-in user is a VIP
-     *                                that event
-     *               [whichPlugin] string: value for that parameter
-     *               [registrationsListPID] integer: value for that parameter
-     *               [registrationsVipListPID] integer: value for that parameter
-     */
-    public function canViewRegistrationsListDataProviderForWorld(): array
-    {
-        return [
-            'seminarListWithNothingElse' => [
-                'expected' => false,
-                'loggedIn' => false,
-                'isRegistered' => false,
-                'isVip' => false,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'seminarListWithListPid' => [
-                'expected' => true,
-                'loggedIn' => false,
-                'isRegistered' => false,
-                'isVip' => false,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 0,
-            ],
-            'seminarListLoggedInWithListPid' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => false,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 0,
-            ],
-            'seminarListIsRegisteredWithListPid' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 0,
-            ],
-            'seminarListIsRegisteredWithoutListPid' => [
-                'expected' => false,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'seminarListIsVipWithListPid' => [
-                'expected' => false,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => true,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 1,
-            ],
-            'seminarListIsVipWithoutListPid' => [
-                'expected' => false,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => true,
-                'whichPlugin' => 'seminar_list',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'myEventsIsRegisteredWithListPid' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'my_events',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 1,
-            ],
-            'myEventsIsVipWithVipListPid' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => true,
-                'whichPlugin' => 'my_events',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 1,
-            ],
-            'myVipEventsIsRegisteredWithVipListPid' => [
-                'expected' => false,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'my_vip_events',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 1,
-            ],
-            'myVipEventsIsVipWithVipListPid' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => true,
-                'whichPlugin' => 'my_vip_events',
-                'registrationsListPID' => 1,
-                'registrationsVipListPID' => 1,
-            ],
-            'listRegistrationsIsRegistered' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'list_registrations',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'listRegistrationsIsVip' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => true,
-                'whichPlugin' => 'list_registrations',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'listVipRegistrationsIsRegistered' => [
-                'expected' => false,
-                'loggedIn' => true,
-                'isRegistered' => true,
-                'isVip' => false,
-                'whichPlugin' => 'list_vip_registrations',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-            'listVipRegistrationsIsVip' => [
-                'expected' => true,
-                'loggedIn' => true,
-                'isRegistered' => false,
-                'isVip' => true,
-                'whichPlugin' => 'list_vip_registrations',
-                'registrationsListPID' => 0,
-                'registrationsVipListPID' => 0,
-            ],
-        ];
-    }
-
-    /**
-     * @test
-     *
-     * @dataProvider canViewRegistrationsListDataProviderForWorld
-     */
-    public function canViewRegistrationsListWithNeedsRegistrationAndWorldAccess(
-        bool $expected,
-        bool $loggedIn,
-        bool $isRegistered,
-        bool $isVip,
-        string $whichPlugin,
-        int $registrationsListPID,
-        int $registrationsVipListPID
-    ): void {
-        $subject = $this->createPartialMock(
-            LegacyEvent::class,
-            ['needsRegistration', 'isUserRegistered', 'isUserVip']
-        );
-        $subject->method('needsRegistration')
-            ->willReturn(true);
-        $subject->method('isUserRegistered')
-            ->willReturn($isRegistered);
-        $subject->method('isUserVip')
-            ->willReturn($isVip);
-
-        if ($loggedIn) {
-            $rootPageUid = $this->testingFramework->createFrontEndPage();
-            $this->testingFramework->changeRecord('pages', $rootPageUid, ['slug' => '/home']);
-            $this->testingFramework->createFakeFrontEnd($rootPageUid);
-            $this->testingFramework->createAndLoginFrontEndUser();
-        }
-
-        self::assertSame(
-            $expected,
-            $subject->canViewRegistrationsList(
-                $whichPlugin,
-                $registrationsListPID,
-                $registrationsVipListPID,
-                'world'
-            )
-        );
-    }
-
     // Tests concerning canViewRegistrationsListMessage
 
     /**
@@ -6855,20 +6655,6 @@ public function canViewRegistrationsListMessageForListAndNoLoginAndLoginAccessRe
         );
     }
 
-    /**
-     * @test
-     */
-    public function canViewRegistrationsListMessageForListAndNoLoginAndWorldAccessReturnsEmptyString(): void
-    {
-        $subject = $this->createPartialMock(LegacyEvent::class, ['needsRegistration']);
-        $subject->method('needsRegistration')->willReturn(true);
-
-        self::assertSame(
-            '',
-            $subject->canViewRegistrationsListMessage('list_registrations', 'world')
-        );
-    }
-
     /**
      * Data provider that returns all possible access level codes for the
      * FE registration lists.
@@ -6900,20 +6686,6 @@ public function canViewRegistrationsListMessageForVipListAndNoLoginReturnsPlease
         );
     }
 
-    /**
-     * @test
-     */
-    public function canViewRegistrationsListMessageForVipListAndWorldAccessAndNoLoginReturnsEmptyString(): void
-    {
-        $subject = $this->createPartialMock(LegacyEvent::class, ['needsRegistration']);
-        $subject->method('needsRegistration')->willReturn(true);
-
-        self::assertSame(
-            '',
-            $subject->canViewRegistrationsListMessage('list_vip_registrations', 'world')
-        );
-    }
-
     /**
      * Data provider that returns all possible parameter combinations for
      * canViewRegistrationsList as called from canViewRegistrationsListMessage.
@@ -6925,10 +6697,8 @@ public function registrationListParametersDataProvider(): array
         return [
             'attendeesAndManagers' => ['list_registrations', 'attendees_and_managers'],
             'login' => ['list_registrations', 'login'],
-            'world' => ['list_registrations', 'world'],
             'attendeesAndManagersVip' => ['list_vip_registrations', 'attendees_and_managers'],
             'loginVip' => ['list_vip_registrations', 'login'],
-            'worldVip' => ['list_vip_registrations', 'world'],
         ];
     }
 
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ private function checkAccessToFrontEndRegistrationLists(): void`
`146`	`146`	`'This value specifies who is able to see the registered persons an event in the front end .`
`147`	`147`	`If this value is incorrect, persons may access the registration lists although they should not be allowed to`
`148`	`148`	`(or vice versa).',`
`149`		`- ['attendees_and_managers', 'login', 'world']`
	`149`	`+ ['attendees_and_managers', 'login']`
`150`	`150`	`);`
`151`	`151`	`}`
`152`	`152`