Skip to content

Commit d3d9041

Browse files
authored
[TASK] Drop the configuration check for the currency (#4272)
This is another blocker for getting rid of the `static_info_tables` dependency.
1 parent a83f826 commit d3d9041

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

Classes/Configuration/SharedConfigurationCheck.php

-19
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
namespace OliverKlee\Seminars\Configuration;
66

77
use OliverKlee\Oelib\Configuration\AbstractConfigurationCheck;
8-
use TYPO3\CMS\Core\Database\ConnectionPool;
9-
use TYPO3\CMS\Core\Utility\GeneralUtility;
108

119
/**
1210
* Configuration check for all settings in `plugin.tx_seminars`.
@@ -17,7 +15,6 @@ class SharedConfigurationCheck extends AbstractConfigurationCheck
1715
{
1816
protected function checkAllConfigurationValues(): void
1917
{
20-
$this->checkCurrency();
2118
$this->checkGeneralPriceInMail();
2219
$this->checkRegistrationFlag();
2320
$this->checkSalutationMode();
@@ -32,22 +29,6 @@ protected function checkAllConfigurationValues(): void
3229
}
3330
}
3431

35-
/**
36-
* Checks whether `plugin.tx_seminars.currency` is not empty and a valid ISO 4217 alpha 3.
37-
*/
38-
private function checkCurrency(): void
39-
{
40-
$connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('static_currencies');
41-
$result = $connection->select(['cu_iso_3'], 'static_currencies')->fetchAllAssociative();
42-
$allowedValues = \array_column($result, 'cu_iso_3');
43-
44-
$this->checkIfSingleInSetNotEmpty(
45-
'currency',
46-
'The specified currency setting is either empty or not a valid ISO 4217 alpha 3 code.',
47-
$allowedValues
48-
);
49-
}
50-
5132
private function checkGeneralPriceInMail(): void
5233
{
5334
$this->checkIfBoolean(

phpstan-baseline.neon

-5
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,6 @@ parameters:
115115
count: 1
116116
path: Classes/Configuration/EventRegistrationFlexForms.php
117117

118-
-
119-
message: "#^Parameter \\#3 \\$allowedValues of method OliverKlee\\\\Oelib\\\\Configuration\\\\AbstractConfigurationCheck\\:\\:checkIfSingleInSetNotEmpty\\(\\) expects array\\<string\\>, array\\<int, mixed\\> given\\.$#"
120-
count: 1
121-
path: Classes/Configuration/SharedConfigurationCheck.php
122-
123118
-
124119
message: "#^Provide more specific return type \"OliverKlee\\\\Seminars\\\\Csv\\\\CsvResponse\" over abstract one$#"
125120
count: 1

0 commit comments

Comments
 (0)