Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Make the event statistics internal #4074

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

oliverklee
Copy link
Owner

They will be refactored quite soon and hence will change drastically.

Hence they must not be public interface.

Fixes #4073

They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

Fixes #4073
@oliverklee oliverklee force-pushed the task/statistics-internal branch from a22b764 to 8f8d138 Compare January 22, 2025 10:47
oliverklee added a commit that referenced this pull request Jan 22, 2025
They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

Fixes #4073

This is the 5.x backport of #4074.
oliverklee added a commit that referenced this pull request Jan 22, 2025
They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

This is the 5.x backport of #4074.

Fixes #4073
@oliverklee oliverklee merged commit 6f023d8 into main Jan 22, 2025
53 checks passed
@oliverklee oliverklee deleted the task/statistics-internal branch January 22, 2025 10:53
@coveralls
Copy link

coveralls commented Jan 22, 2025

Coverage Status

coverage: 90.378%. remained the same
when pulling 8f8d138 on task/statistics-internal
into 6a24ab3 on main.

oliverklee added a commit that referenced this pull request Jan 22, 2025
They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

This is the 5.x backport of #4074.

Fixes #4073
oliverklee added a commit that referenced this pull request Feb 19, 2025
They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

This is the 5.x backport of #4074.

Fixes #4073
oliverklee added a commit that referenced this pull request Feb 19, 2025
They will be refactored quite soon and hence will change
drastically.

Hence they must not be public interface.

This is the 5.x backport of #4074.

Fixes #4073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make EventStatistics, EventStatisticsCalculator and getStatistics internal
2 participants