Linting

Author: pboling

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-02-14 08:34:14 UTC using RuboCop version 1.9.1.
+# on 2021-03-21 02:34:29 UTC using RuboCop version 1.11.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -34,7 +34,7 @@ Lint/NestedMethodDefinition:
 # Offense count: 1
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 42
+  Max: 30
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
@@ -45,22 +45,17 @@ Metrics/BlockLength:
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 140
-
-# Offense count: 1
-# Configuration parameters: IgnoredMethods.
-Metrics/CyclomaticComplexity:
-  Max: 9
+  Max: 145
 
 # Offense count: 7
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
-  Max: 21
+  Max: 20
 
 # Offense count: 2
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 11
+  Max: 9
 
 # Offense count: 1
 Naming/AccessorMethodName:
@@ -131,14 +126,14 @@ RSpec/LeakyConstantDeclaration:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 8
+# Offense count: 9
 RSpec/MultipleExpectations:
   Max: 4
 
-# Offense count: 3
+# Offense count: 14
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
-  Max: 6
+  Max: 8
 
 # Offense count: 44
 # Configuration parameters: IgnoreSharedExamples.
@@ -148,9 +143,9 @@ RSpec/NamedSubject:
     - 'spec/omniauth/identity/models/couch_potato_spec.rb'
     - 'spec/omniauth/identity/models/mongoid_spec.rb'
 
-# Offense count: 6
+# Offense count: 12
 RSpec/NestedGroups:
-  Max: 4
+  Max: 5
 
 # Offense count: 4
 RSpec/StubbedMock:

spec/omniauth/strategies/identity_spec.rb

@@ -226,10 +226,12 @@ def set_app!(identity_options = {})
             post '/auth/identity/register', properties
             expect(env_hash).to eq(nil)
           end
+
           it 'renders registration form' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:registration_form_title])
           end
+
           it 'displays validation failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:validation_failure_message])
@@ -242,19 +244,23 @@ def set_app!(identity_options = {})
               true
             }
           end
+
           it 'sets the auth hash' do
             post '/auth/identity/register', properties
             expect(auth_hash['uid']).to match(/\d+/)
             expect(auth_hash['provider']).to eq('identity')
           end
+
           it 'does not render registration form' do
             post '/auth/identity/register', properties
             expect(last_response.body).not_to be_include(described_class.default_options[:registration_form_title])
           end
+
           it 'does not display validation failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).not_to be_include(described_class.default_options[:validation_failure_message])
           end
+
           it 'does not display registration failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).not_to be_include(described_class.default_options[:registration_failure_message])
@@ -317,10 +323,12 @@ def set_app!(identity_options = {})
             post '/auth/identity/register', properties
             expect(env_hash).to eq(nil)
           end
+
           it 'renders registration form' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:registration_form_title])
           end
+
           it 'displays validation failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:validation_failure_message])
@@ -333,18 +341,22 @@ def set_app!(identity_options = {})
               true
             }
           end
+
           it 'does not set the env hash' do
             post '/auth/identity/register', properties
             expect(env_hash).to eq(nil)
           end
+
           it 'renders registration form' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:registration_form_title])
           end
+
           it 'does not display validation failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).not_to be_include(described_class.default_options[:validation_failure_message])
           end
+
           it 'display registration failure message' do
             post '/auth/identity/register', properties
             expect(last_response.body).to be_include(described_class.default_options[:registration_failure_message])