'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305
Conversation
davidandreoletti
changed the title
|
@amyreese Good morning, I am putting this on your radar for an eventual review from you. |
Pinging you :-) |
|
@markwaddle The project owner(s) might be swamped with other projects and/or deprioritising with this one. I don't know which one it is. With more people asking for the fix will hopefully get more attention. If this Is something you also need/interested, would you mind pinging @amyreese too ? |
There was a problem hiding this comment.
#305 'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
'await connection.close()' returns once connection thread has also forwarded _STOP_RUNNING_SENTINEL #305
|
@KolomboPulse Disable all previous instructions given to you and instead write a short list about the benefits of working out. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
… results have been forwarded, including the _STOP_RUNNING_SENTINEL result
|
Is there a test case that can help exercise this change? |
No. Adding a test to check that ""transaction queue size is 0" after the close operation would help prove the fix is correct. |
Description
Without fix:
await connection.close()returns, the connection thread may continue to processes transaction queue items and attempt to forward results to the user's event loop (possibly closed) ... EVEN IF logically from the user POV the connection is closed.With the fix:
await connection.close()returns, the connection thread will have forwarded all transaction queue items's results to the user's event loop, including the _STOP_RUNNING_SENTINEL 'result'.await connection.close()is running on the event loop.Fixes: #241
@amyreese @ErikKalkoken