Skip to content

Commit a4d2a39

Browse files
committed
fix: minor improvements and UI bug fixes
1 parent 0d5ca92 commit a4d2a39

File tree

8 files changed

+13
-10
lines changed

8 files changed

+13
-10
lines changed

src/once-ui/components/Checkbox.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
height: var(--static-space-20);
2121
min-width: var(--static-space-20);
2222
min-height: var(--static-space-20);
23-
transition: border-color 0.3s;
23+
transition: var(--transition-property) var(--transition-duration-micro-medium) var(--transition-timing-function);
2424
outline: none;
2525

2626
&.checked {

src/once-ui/components/InlineCode.module.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
display: inline;
33
padding: var(--static-space-1) var(--static-space-4);
44
border-radius: var(--radius-s);
5-
background: var(--neutral-background-strong);
6-
border: 1px solid var(--neutral-border-strong);
5+
background: var(--neutral-alpha-weak);
6+
border: 1px solid var(--neutral-alpha-medium);
77
font-family: var(--font-family-code);
88
font-size: 80%;
99
margin: 0 var(--static-space-2);

src/once-ui/components/InteractiveDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import React, { forwardRef } from 'react';
44
import { Text, Flex, IconButton, IconButtonProps } from '.';
55

66
interface InteractiveDetailsProps {
7-
label: string;
7+
label?: string;
88
description?: string;
99
iconButtonProps?: IconButtonProps;
1010
onClick: () => void;

src/once-ui/components/Scroller.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
bottom: 0;
2929
width: var(--static-space-64);
3030
height: 100%;
31-
z-index: 0;
31+
z-index: 1;
3232
}
3333

3434
.scrollMaskPrev {

src/once-ui/components/Scroller.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ interface ScrollerProps {
1111
contained?: boolean;
1212
className?: string;
1313
style?: React.CSSProperties;
14+
[key: string]: any;
1415
}
1516

1617
const Scroller: React.FC<ScrollerProps> = ({
@@ -75,8 +76,7 @@ const Scroller: React.FC<ScrollerProps> = ({
7576
overflowX: "hidden",
7677
overflowY: "hidden",
7778
})}
78-
style={style}
79-
{...props}>
79+
style={style}>
8080
{showPrevButton && (
8181
<div className={classNames(styles.scrollMaskContainer, styles.scrollMaskPrev)}>
8282
<div className={styles.scrollMask}></div>
@@ -95,7 +95,8 @@ const Scroller: React.FC<ScrollerProps> = ({
9595
className={classNames(styles.scroller, {
9696
[styles.row]: direction === 'row',
9797
[styles.column]: direction === 'column',
98-
})}>
98+
})}
99+
{...props}>
99100
{children}
100101
</Flex>
101102
{showNextButton && (

src/once-ui/components/Switch.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,11 @@ const Switch = forwardRef<HTMLDivElement, SwitchProps>(({
5555
[styles.checked]: isChecked,
5656
})}/>
5757
</div>
58+
{ interactiveDetailsProps.label && (
5859
<InteractiveDetails
5960
{...interactiveDetailsProps}
6061
onClick={() => {}}/>
62+
)}
6163
</Flex>
6264
);
6365
});

src/once-ui/components/Tag.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const Tag = forwardRef<HTMLDivElement, TagProps>(({
3737
className={classNames(styles.tag, styles[variant], styles[size], className)}
3838
{...props}>
3939
{prefixIcon && <Icon name={prefixIcon} size="xs" />}
40-
<Flex
40+
<Flex style={{userSelect: 'none'}}
4141
paddingX={paddingSize}
4242
alignItems="center">
4343
<Text

src/once-ui/components/Tooltip.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const Tooltip = forwardRef<HTMLDivElement, TooltipProps>(({
2424
style={{ whiteSpace: 'nowrap', userSelect: 'none' }}
2525
gap="4"
2626
zIndex={1}
27-
background="neutral-medium"
27+
background="surface"
2828
paddingY="4"
2929
paddingX="8"
3030
radius="s"

0 commit comments

Comments
 (0)