Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Reduce YAML libraries in Core. #409

Open
aleksandrmelnikov opened this issue Jul 14, 2020 · 1 comment
Open

Refactor and Reduce YAML libraries in Core. #409

aleksandrmelnikov opened this issue Jul 14, 2020 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@aleksandrmelnikov
Copy link
Contributor

aleksandrmelnikov commented Jul 14, 2020 •
edited
Loading

We use yaml.v3 to support reading (and writing) YAML with comments, inline comments, and other metadata.
We use a pkg/config_types.go in CLI to marshal / unmarshal params.yaml
Same package is used in core to dynamically generate the s3 access and secret keys, for Workflows
I think, ideally, we should use yaml.v3

See: #400 (comment)

Thursday, July 23, 2020 - 09_10_47 PM
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/enhancement to this issue, with a confidence of 0.92. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the kind/enhancement New feature or request label Jul 14, 2020
@aleksandrmelnikov aleksandrmelnikov mentioned this issue Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleksandrmelnikov