Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs regarding beta.kubernetes.io/instance-type #420

Open
aleksandrmelnikov opened this issue Jul 23, 2020 · 1 comment
Open

Update docs regarding beta.kubernetes.io/instance-type #420

aleksandrmelnikov opened this issue Jul 23, 2020 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@aleksandrmelnikov
Copy link
Contributor

Ref: https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/#beta-kubernetes-io-instance-type-deprecated

As of k8s 1.17, beta.kubernetes.io/instance-type is deprecated.

Use:
node.kubernetes.io/instance-type instead.

We should add a note / disclaimer in the docs.
Example spot: https://docs.onepanel.ai/docs/deployment/configuration/files/#application
@issue-label-bot issue-label-bot bot added the kind/enhancement New feature or request label Jul 23, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/enhancement to this issue, with a confidence of 0.64. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleksandrmelnikov