fix(sneak/#2179): Stale sneaks shown in UI (#3542)

__Issue:__ There were some cases where stale sneaks were left in the UI. 

__Defect:__ There are some cases where the `Hooks.effect(OnMountAndIf)` doesn't seem to be calling the disposal handler.

__Fix:__ Collect the sneaks every render, ensuring we have the latest sneakable elements when sneak is opened.

Fixes #2568 
Fixes #2179

Author: bryphe

src/Feature/Sneak/Feature_Sneak.re

@@ -149,9 +149,9 @@ module Registry = {
     id;
   };
 
-  let unregister = id => {
-    let filter = sneakInfo => sneakInfo.id !== id;
-    MutableState.singleton := List.filter(filter, MutableState.singleton^);
+  let reset = () => {
+    MutableState.nextId := 0;
+    MutableState.singleton := [];
   };
 
   let getSneaks = () => {
@@ -247,6 +247,8 @@ module View = {
   open Revery.UI;
   open Revery.UI.Components;
 
+  let reset = Registry.reset;
+
   module Colors = Feature_Theme.Colors;
 
   module Constants = {
@@ -333,7 +335,7 @@ module View = {
                   (
                     ~sneakId,
                     ~style=[],
-                    ~onClick=() => (),
+                    ~onClick=?,
                     ~onRightClick=() => (),
                     ~onAnyClick=_ => (),
                     ~onDoubleClick=() => (),
@@ -352,25 +354,19 @@ module View = {
                   ) => {
       let%hook bboxRef = Hooks.ref(None);
 
-      let%hook () =
-        Hooks.effect(
-          OnMountAndIf((!=), sneakId),
-          () => {
-            let maybeId =
-              switch (onSneak) {
-              | Some(cb) => Some(Registry.register(bboxRef, cb))
-              | None => Some(Registry.register(bboxRef, onClick))
-              };
-
-            Some(
-              () => {maybeId |> Option.iter(id => Registry.unregister(id))},
-            );
-          },
-        );
+      ignore(sneakId);
+
+      switch (onSneak, onClick) {
+      | (Some(sneakCallback), _) =>
+        ignore(Registry.register(bboxRef, sneakCallback): int)
+      | (None, Some(clickCallback)) =>
+        ignore(Registry.register(bboxRef, clickCallback): int)
+      | _ => ()
+      };
 
       <Clickable
         style
-        onClick
+        ?onClick
         onRightClick
         onAnyClick
         onDoubleClick

src/Feature/Sneak/Feature_Sneak.rei

@@ -39,6 +39,7 @@ type outmsg =
 let update: (model, msg) => (model, outmsg);
 
 module View: {
+  let reset: unit => unit;
   module Sneakable: {
     let make:
       (

src/bin_editor/Oni2_editor.re

@@ -390,7 +390,11 @@ switch (eff) {
       let uiDispatch = ref(_ => ());
 
       let update =
-        UI.start(window, <Root state=currentState^ dispatch=uiDispatch^ />);
+        UI.start(
+          ~onBeforeRender=() => Feature_Sneak.View.reset(),
+          window,
+          <Root state=currentState^ dispatch=uiDispatch^ />,
+        );
 
       let setTitle = title => {
         Window.setTitle(window, title);