-
Notifications
You must be signed in to change notification settings - Fork 30
Fastpath writes to disk #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together it looks very good. I have left a few comments for things to change. Once addressed we can move it forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Next steps to get this deployed in production:
|
With our current setup the API in the monolith is writing report data to disk with the
/report/{id}
endpoint while also sending the same data to the fastpath.This data is meant to be processed by the api uploader.
However since we intend to move this setup to AWS, we need a different approach, see #968
This PR will move the file-writing part to the Fastpath once the measurement is received. This is necessary because the ooniprobe service is unable to share disk with the EC2 machine running fastpath and api uploader
The file-writing feature is under a feature flag and deactivated by default. To activate it we add this in
fastpath.conf
It will also add the config parameter
msmt_spool_dir
to the configuration file. It will only be parsed whenwrite_to_disk == true
depends on #969
closes #968