Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: record the transport used to submit #1857

Open
bassosimone opened this issue Oct 28, 2021 · 1 comment
Open

engine: record the transport used to submit #1857

bassosimone opened this issue Oct 28, 2021 · 1 comment
Assignees
Labels
bug Something isn't working correctly GSoC GSoC related issues ooni/probe-cli ooni/probe-engine priority/low Nice to have

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 28, 2021

This issue is about helping the backend to figure out which transport has been used to submit a measurement. I am against adding this information directly inside the measurement because it strikes me as a bad idea to mutate the measurement to add an extra field just before submitting (it screams data race and I don't like it). So, my inclination here would be to add a header to the request that says which is the transport we're currently using. Then, we could teach the API or monitoring to know and record which is the transport that has been used.

@bassosimone bassosimone added the bug Something isn't working correctly label Oct 28, 2021
@bassosimone bassosimone self-assigned this Oct 28, 2021
@bassosimone bassosimone added priority/low Nice to have priority/high Important issue that needs attention soon and removed priority/low Nice to have labels Nov 8, 2021
@hellais hellais added this to Roadmap Jan 7, 2025
@hellais hellais assigned DecFox and unassigned bassosimone Jan 23, 2025
@hellais hellais added priority/low Nice to have and removed priority/high Important issue that needs attention soon labels Jan 23, 2025
@hellais hellais moved this to Backlog in Roadmap Jan 23, 2025
@hellais hellais removed this from Roadmap Jan 29, 2025
@hellais
Copy link
Member

hellais commented Jan 30, 2025

This should be done once we have #2844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly GSoC GSoC related issues ooni/probe-cli ooni/probe-engine priority/low Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants