Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: plan how we expose all logs to mobile apps #1992

Closed
bassosimone opened this issue Jan 28, 2022 · 1 comment
Closed

engine: plan how we expose all logs to mobile apps #1992

bassosimone opened this issue Jan 28, 2022 · 1 comment
Assignees
Labels
bug Something isn't working correctly GSoC GSoC related issues ooni/probe-engine ooni/probe-mobile issues related to OONI Probe mobile platform/android priority/medium Normal priority issue techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

This issue is about improving how we expose the engine logs to mobile apps. The main drawback we would like to address is that it's difficult for a user to see errors occurring in the mobile apps early during the experiment flow (more on this later). We will consider this issue resolved when we'll have a design and a plan to allow accessing logs.

More in detail, the current scheme is that we're passing logs to the mobile app while the test is running and the app will in turn do something sensible with these logs such as storing them. Yet, the main implementation drawback is that the app does not even bother with storing logs if an experiment fails early. This is a bummer because early logs are the ones that are more likely to be telling in case of blocking of our core services. Hence, we're basically hiding the most useful logs.

I suppose the first step is investigating if we can restructure logging in the app without changing the engine. It may be difficult since my understanding of why the app is not saving those logs is that there is really no test inside the database and so there is no logical "thing" know to the app that the logs may be attached to. If that turns out to be the case, maybe we can add some sort of "logcat" to the engine, which guarantees that at least we always have logs for the user.

@bassosimone bassosimone added bug Something isn't working correctly ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue user feedback requests that have been added to the backlog as a direct result of user feedback or testing platform/android ooni/probe-engine techdebt This issue describes technical debt labels Jan 28, 2022
@bassosimone bassosimone self-assigned this Jan 28, 2022
@bassosimone bassosimone added the GSoC GSoC related issues label Feb 18, 2022
@bassosimone
Copy link
Contributor Author

So, previously, we said:

[...] We will consider this issue resolved when we'll have a design and a plan to allow accessing logs.

We now have a plan and a prototype here: ooni/probe-android#516.

We also have a second-step part of the plan here #2143.

Hence, we can consider this issue resolved.

@bassosimone bassosimone changed the title engine: improve how we expose logs to mobile apps engine: plan how we expose all logs to mobile apps Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly GSoC GSoC related issues ooni/probe-engine ooni/probe-mobile issues related to OONI Probe mobile platform/android priority/medium Normal priority issue techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Development

No branches or pull requests

1 participant