Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting context of strings in ooni/translations #981

Closed
hellais opened this issue Jan 21, 2020 · 1 comment
Closed

Add support for setting context of strings in ooni/translations #981

hellais opened this issue Jan 21, 2020 · 1 comment
Assignees
Labels
copy ooni/probe-desktop ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue

Comments

@hellais
Copy link
Member

hellais commented Jan 21, 2020

It was reported that:

For the six "Blocked", "Tested" and "Working" strings, could you please add the explanation in the string description field since not every language team collaborators will read the comments/issues?

But because of how we set the comment field of the context of a string, this would be overwritten next time we do a sync.

See: https://github.com/ooni/translations/blob/master/tx-set-context.py#L59.

We should maybe add an additional column to the master CSV and include the context comment in there.

@hellais
Copy link
Member Author

hellais commented Jan 27, 2025

Closing this in light of #2845

@hellais hellais closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Done in Roadmap Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copy ooni/probe-desktop ooni/probe-mobile issues related to OONI Probe mobile priority/medium Normal priority issue
Projects
Archived in project
Development

No branches or pull requests

3 participants