Fix: no new line at eof (#109)

* fix no new line at eof

Signed-off-by: xuezhaojun <[email protected]>

* Add linelint in github workflow

Signed-off-by: xuezhaojun <[email protected]>

* fix issues found by lint

Signed-off-by: xuezhaojun <[email protected]>

.github/workflows/go-postsubmit.yml

@@ -70,4 +70,4 @@ jobs:
             quay.io/open-cluster-management/cluster-proxy:latest-arm64 --arch arm64
       - name: push
         run: |
-          docker manifest push quay.io/open-cluster-management/cluster-proxy:latest
+          docker manifest push quay.io/open-cluster-management/cluster-proxy:latest

.github/workflows/go-presubmit.yml

@@ -36,7 +36,14 @@ jobs:
           go-version: ${{ env.GO_VERSION }}
       - name: build
         run: make build
-
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Linelint
+        uses: fernandrone/[email protected]
   unit:
     name: unit
     runs-on: ubuntu-latest
@@ -68,7 +75,7 @@ jobs:
           go-version: ${{ env.GO_VERSION }}
       - name: integration
         run: make test-integration
-  
+
   e2e:
     name: e2e
     runs-on: ubuntu-latest

.github/workflows/go-release.yml

@@ -138,4 +138,4 @@ jobs:
             } catch(error) {
               console.error(error);
               core.setFailed(error);
-            }
+            }

.linelint.yml

@@ -0,0 +1,6 @@
+rules:
+  end-of-file:
+    enable: true
+    ignore:
+      - FQA.md
+      - hack/boilerplate.go.txt

charts/cluster-proxy/templates/clusterrole.yaml

@@ -104,4 +104,4 @@ rules:
     resources:
       - leases
     verbs:
-      - "*"
+      - "*"

charts/cluster-proxy/templates/manager-deployment.yaml

@@ -22,4 +22,4 @@ spec:
             - /manager
           args:
             - --leader-elect=true
-            - --signer-secret-namespace={{ .Release.Namespace }}
+            - --signer-secret-namespace={{ .Release.Namespace }}

charts/cluster-proxy/templates/role.yaml

@@ -36,4 +36,4 @@ rules:
       - get
       - create
       - update
-      - patch
+      - patch

charts/cluster-proxy/values.yaml

@@ -18,4 +18,4 @@ proxyAgentImage: quay.io/open-cluster-management/cluster-proxy:v0.2.0
 proxyServer:
   entrypointLoadBalancer: false
   entrypointAddress: ""
-  port: 8091
+  port: 8091

hack/crd/addon/clustermanagementaddon.yaml

@@ -93,4 +93,4 @@ status:
     kind: ""
     plural: ""
   conditions: []
-  storedVersions: []
+  storedVersions: []

hack/crd/addon/managedclusteraddon.yaml

@@ -251,4 +251,4 @@ status:
     kind: ""
     plural: ""
   conditions: []
-  storedVersions: []
+  storedVersions: []

hack/samples/managedcluster.yaml

@@ -3,4 +3,4 @@ kind: ManagedCluster
 metadata:
   name: local
 spec:
-  hubAcceptsClient: false
+  hubAcceptsClient: false

hack/samples/managedproxyconfiguration.yaml

@@ -15,4 +15,3 @@ spec:
       loadBalancerService: {}
   proxyAgent:
     image: "yue9944882/proxy-agent-amd64:v0.0.22"
-    proxyServerHost:

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/addon-agent-deployment.yaml

@@ -98,4 +98,4 @@ spec:
       imagePullSecrets:
       {{- range .Values.proxyAgentImagePullSecrets }}
       - name: {{ . }}
-      {{- end }}
+      {{- end }}

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/addon-agent-role.yaml

@@ -9,4 +9,4 @@ rules:
     resources:
       - leases
     verbs:
-      - '*'
+      - '*'

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/addon-agent-rolebinding.yaml

@@ -10,4 +10,4 @@ roleRef:
 subjects:
   - kind: ServiceAccount
     name: cluster-proxy
-    namespace: {{ .Release.Namespace }}
+    namespace: {{ .Release.Namespace }}

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/ca-secret.yaml

@@ -4,4 +4,4 @@ metadata:
   namespace: {{ .Release.Namespace }}
   name: cluster-proxy-ca
 data:
-  "ca.crt": {{ .Values.base64EncodedCAData }}
+  "ca.crt": {{ .Values.base64EncodedCAData }}

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/cluster-service.yaml

@@ -5,4 +5,4 @@ metadata:
   name: {{ .Values.clusterName }}
 spec:
   type: ExternalName
-  externalName: kubernetes.default.{{ .Values.serviceDomain }}
+  externalName: kubernetes.default.{{ .Values.serviceDomain }}

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/namespace.yaml

@@ -5,4 +5,4 @@ metadata:
   name: {{ .Release.Namespace }}
   annotations:
     helm.sh/resource-policy: keep
-{{ end }}
+{{ end }}

pkg/proxyagent/agent/manifests/charts/addon-agent/templates/service-account.yaml

@@ -2,4 +2,4 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   namespace: {{ .Release.Namespace }}
-  name: cluster-proxy
+  name: cluster-proxy

pkg/proxyagent/agent/manifests/charts/addon-agent/values.yaml

@@ -31,4 +31,4 @@ serviceEntryPointPort: 8091
 
 base64EncodedCAData: Zm9vCg==
 
-serviceDomain: ""
+serviceDomain: ""