Skip to content

Commit 3ca43a4

Browse files
aepflibeeme1mr
andcommitted
Update providers/openfeature-provider-flagd/README.md
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
1 parent 43e30b8 commit 3ca43a4

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

providers/openfeature-provider-flagd/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# flagd Provider for OpenFeature
22

3-
This provider is designed to use
4-
flagd's [evaluation protocol](https://github.com/open-feature/schemas/blob/main/protobuf/schema/v1/schema.proto).
3+
This provider is designed to use flagd's [evaluation protocol](https://github.com/open-feature/schemas/blob/main/protobuf/schema/v1/schema.proto), or locally evaluate flags defined in a flagd [flag definition](https://github.com/open-feature/schemas/blob/main/json/flagd-definitions.json) via the OpenFeature Python SDK.
54

65
## Installation
76

@@ -54,7 +53,7 @@ The value is updated with every (re)connection to the sync implementation.
5453
This can be used to enrich evaluations with such data.
5554
If the `in-process` mode is not used, and before the provider is ready, the `getSyncMetadata` returns an empty map.
5655
-->
57-
#### Offline mode
56+
### File mode
5857

5958
In-process resolvers can also work in an offline mode.
6059
To enable this mode, you should provide a valid flag configuration file with the option `offlineFlagSourcePath`.
@@ -65,7 +64,7 @@ from openfeature.contrib.provider.flagd import FlagdProvider
6564
from openfeature.contrib.provider.flagd.config import ResolverType
6665

6766
api.set_provider(FlagdProvider(
68-
resolver_type=ResolverType.IN_PROCESS,
67+
resolver_type=ResolverType.FILE,
6968
offline_flag_source_path="my-flag.json",
7069
))
7170
```

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def listen(self) -> None:
178178
self.connected = True
179179

180180
if not self.active:
181-
logger.info("Terminating gRPC sync thread")
181+
logger.debug("Terminating gRPC sync thread")
182182
return
183183
except grpc.RpcError as e: # noqa: PERF203
184184
logger.error(f"SyncFlags stream error, {e.code()=} {e.details()=}")
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
1-
import sys
2-
31
from pytest_bdd import scenarios
42

53
from tests.e2e.paths import TEST_HARNESS_PATH
64

7-
# as soon as we support all the features, we can actually remove this limitation to not run on Python 3.8
8-
# Python 3.8 does not fully support tagging, hence that it will run all cases
9-
if sys.version_info >= (3, 9):
10-
scenarios(f"{TEST_HARNESS_PATH}/gherkin")
5+
scenarios(f"{TEST_HARNESS_PATH}/gherkin")

0 commit comments

Comments
 (0)