Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get parts of the existing work merged (e.g. radio component) #1515

Open
2 tasks
Tracked by #1512
sergei-maertens opened this issue Apr 20, 2022 · 2 comments
Open
2 tasks
Tracked by #1512

Get parts of the existing work merged (e.g. radio component) #1515

sergei-maertens opened this issue Apr 20, 2022 · 2 comments

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Apr 20, 2022

open-formulieren/open-forms-sdk#187 contains some NL DS components already that should be fairly straightforward to get reviewed and merged.

Break up this PR so that for every (Formio) component, there is a separate PR.

Also consider taking #1519 in account for things we can already resolve at the component level.

Components

  • Radio
  • ... (@bddjong please complete this list)
@bddjong
Copy link

bddjong commented May 11, 2022

@sergei-maertens
Components that we changed to use NLDS design tokens

  • Radio
  • Buttons
  • Checkbox
  • Text-field
  • Text-area
  • Combobox
  • Select
  • Datepicker

@bddjong
Copy link

bddjong commented May 18, 2022

@sergei-maertens I'm starting work on creating PR's for separate components from the nl-design-system fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants