Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update street and city fields when (bag) service retrurns a valid response. #3748

Open
LaurensBurger opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
enhancement triage Issue needs to be validated. Remove this label if the issue considered valid.

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jan 9, 2024

Thema / Theme

Frontend

Omschrijving / Description

Scenario:
User provides valid postcode and house number, but notices they made a mistake.
User then proceeds to correct the mistake.
Streetname and City will not update because they contain data, and this is the condition that is used to prevent a new query.

As a user i expect when i change is postcode and house number to update street and city fields automatically, because this is what i experienced the first time i entered these fields.
This should only occur when/if the (bag) service returns valid street & city data to prevent the "removing" of previous entered data in these fields as described in:
#1717

Aanvullende opmerkingen / Additional context

We could also inform the user if a location plugin is active and service does not return a street and city. provide them a trigger to empty the fields (street/city)

@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jan 9, 2024
@sergei-maertens
Copy link
Member

sergei-maertens commented Jan 9, 2024

This issue has a long history and we are aware that we need more control about the behaviour.

Currently, autofill only overwrites existing/filled data if the fields are marked as read-only.

Technically with the current renderer, we can not tell the difference between data that was entered via the autofill or by a manual action of the user, so we can not apply a heuristic "update the fields unless the user manually changed the values".

Related issues: #1832, #1717, #2566

There is potential to further develop our new addressNL plugin with this behaviour, which addresses your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement triage Issue needs to be validated. Remove this label if the issue considered valid.
Projects
None yet
Development

No branches or pull requests

3 participants