Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZGW registration backend: validation that domain's must be uppercase seems incorrect #5024

Open
alextreme opened this issue Jan 17, 2025 · 2 comments
Labels
enhancement needs-backport Fix must be backported to stable release branch owner: maykin

Comments

@alextreme
Copy link
Contributor

alextreme commented Jan 17, 2025

Product versie / Product version

3.0.1

Customer reference

Taiga Brabantse Delta #40

Omschrijf het probleem / Describe the bug

When integrating with Djuma we came across a catalog which isn't fully uppercased.

I know in Open Zaak that having a domain in capitals is mandatory, however this doesn't seem to be part of the ZGW API standard

https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/VNG-Realisatie/catalogi-api/1.3.1/src/openapi.yaml#tag/catalogussen/operation/catalogus_create

I would suggest to replace this validation check with one that allows upper and lowercase characters

validators=[validate_uppercase],

For further details see the Taiga issue

@alextreme alextreme added bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 17, 2025
@joeribekker
Copy link
Contributor

Refinement: This isnt a bug in Open Forms since the ImZTC does require it. I don't blame Djuma for not knowing (well, a little since they are used to StUF-ZDS) because its not in the API spec.

Image

We can however relax this on our side since Open Forms doesnt need to enforce a requirement when reading a catalog.

@joeribekker joeribekker added enhancement and removed bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 20, 2025
@joeribekker
Copy link
Contributor

ie. we'll remove the validation

@joeribekker joeribekker added needs-backport Fix must be backported to stable release branch owner: maykin labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-backport Fix must be backported to stable release branch owner: maykin
Projects
None yet
Development

No branches or pull requests

2 participants