Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object registration plugin expects Auth Attribute Path when "update existing object" is not set. #5034

Closed
LaurensBurger opened this issue Jan 24, 2025 · 0 comments · Fixed by #5062
Closed

Object registration plugin expects Auth Attribute Path when "update existing object" is not set. #5034

LaurensBurger opened this issue Jan 24, 2025 · 0 comments · Fixed by #5062
Assignees
@vaszig
Labels
needs-backport Fix must be backported to stable release branch owner: den-haag
Milestone
Release 3.0.2

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jan 24, 2025 •
edited
Loading

Product versie / Product version

3.0.1

Customer reference

DH

Omschrijf het probleem / Describe the bug

Sentry: 391347

When a form had objects API prefill set, but registration is set to not update the same object - instead create a different type of object. The assertion of Auth Attribute Path should be skipped.

Do not update setting
Image

prefill object:
Image
@LaurensBurger LaurensBurger added the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jan 24, 2025
@vaszig vaszig removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jan 27, 2025
@vaszig vaszig added this to the Release 3.0.2 milestone Jan 27, 2025
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Jan 29, 2025
@joeribekker joeribekker assigned vaszig and unassigned stevenbal Jan 30, 2025
@vaszig vaszig moved this from Todo to In Progress in Development Jan 30, 2025
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Added regression tests for ownership validation
2a5c653
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Validate ownership only when the object needs update
9e3e6ba
@vaszig vaszig moved this from In Progress to Implemented in Development Jan 30, 2025
@vaszig vaszig mentioned this issue Jan 30, 2025
Merged
10 tasks
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Added regression tests for ownership validation
f36fbad
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Validate ownership only when the object needs update
eeeabb9
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Added regression tests for ownership validation
b783091
vaszig added a commit that referenced this issue Jan 30, 2025
@vaszig
[#5034] Validate ownership only when the object needs update
8e71ffc
sergei-maertens added a commit that referenced this issue Jan 31, 2025
@sergei-maertens
Merge pull request #5062 from open-formulieren/fix/5034-update-existi…
9f92893 
…ng-object-in-Objects-api-expects-authattribute

[#5034] Fix object ownership in Objects API
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Jan 31, 2025
sergei-maertens pushed a commit that referenced this issue Jan 31, 2025
@vaszig @sergei-maertens
[#5034] Validate ownership only when the object needs update
b74ea05 
Backport-of: #5062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
needs-backport Fix must be backported to stable release branch owner: den-haag
Projects
Development
Archived in project
Milestone
Release 3.0.2
Development

Successfully merging a pull request may close this issue.

[#5034] Fix object ownership in Objects API open-formulieren/open-forms
4 participants
@sergei-maertens @stevenbal @vaszig @LaurensBurger