♻️ [#5044] Add constant for dataSrc options #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
cleanup/5044-data-src-constants
branch
4 times, most recently
from
58b3212 to
ede4fe9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5080 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 770 770
Lines 26524 26534 +10
Branches 3452 3452
=======================================
+ Hits 25656 25666 +10
Misses 606 606
Partials 262 262 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Feb 5, 2025
src/openforms/formio/typing/base.py
Outdated
Comment on lines
48
to
54
| dataSrc: NotRequired[ | ||
| Literal[ | ||
| DataSrcOptions.manual, | ||
| DataSrcOptions.variable, | ||
| DataSrcOptions.referentielijsten, | ||
| ] | ||
| ] |
There was a problem hiding this comment.
I'm fairly certain type checkers don't understand this - type checking is done statically and no python code is actually evaluated.
Suggested change
| dataSrc: NotRequired[ | |
| Literal[ | |
| DataSrcOptions.manual, | |
| DataSrcOptions.variable, | |
| DataSrcOptions.referentielijsten, | |
| ] | |
| ] | |
| dataSrc: NotRequired[DataSrcOptions] |
using the choices class should help enforce that comparisons are made with the constant rather than magic strings, but I haven't tested this.
sergei-maertens
force-pushed
the
cleanup/5044-data-src-constants
branch
from
ede4fe9 to
5fccbdf
Compare
sergei-maertens
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5044
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene