Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to quickly include all form variables in JSON dump plugin #5070

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Add button to quickly include all form variables in JSON dump plugin #5070

merged 3 commits into from
Feb 13, 2025

Conversation

viktorvanwijk
Copy link
Contributor

@viktorvanwijk viktorvanwijk commented Jan 31, 2025 •
edited
Loading

Closes #5066

Changes

Add button to quickly include all form variables in JSON dump plugin

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (06c301c) to head (b916d4b).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5070   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         771      771           
  Lines       26636    26636           
  Branches     3467     3467           
=======================================
  Hits        25770    25770           
  Misses        605      605           
  Partials      261      261

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorvanwijk viktorvanwijk changed the title Add button to quickly include all form varianles in JSON dump plugin Add button to quickly include all form variables in JSON dump plugin Feb 3, 2025
@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch from b11b609 to 1013703 Compare February 3, 2025 08:37
@viktorvanwijk viktorvanwijk marked this pull request as ready for review February 4, 2025 14:10
@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch from 820f230 to 62bc105 Compare February 5, 2025 10:16
viktorvanwijk
viktorvanwijk commented Feb 6, 2025
View reviewed changes
docs/developers/frontend/index.rst
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking now this might be better placed in Backend -> Admin styling?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this would be the correct place. (S)CSS is frontend stuff :)
I would suggest moving this to a separate file, instead of added it to the index.rst, just to give some structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused by the definition of frontend here. If you look at the frontend documentation, it only mentions the repos related to the form frontend, not the admin styling. I guess it depends on what is meant exactly by Backend and Frontend here:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, yeah.. it's a bit confusing.. I assume 'Frontend' contains all things related to frontend code (including the frontend of the open-forms project). I think this is fine, otherwise you can blame me 😉

robinmolen
robinmolen requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments/things to keep in mind :)

docs/developers/frontend/index.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this would be the correct place. (S)CSS is frontend stuff :)
I would suggest moving this to a separate file, instead of added it to the index.rst, just to give some structure.

@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch 4 times, most recently from 0ad3397 to 3819dac Compare February 13, 2025 13:49
@viktorvanwijk viktorvanwijk force-pushed the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch from 3819dac to b916d4b Compare February 13, 2025 15:42
@robinmolen robinmolen merged commit 2ff785d into master Feb 13, 2025
33 checks passed
@robinmolen robinmolen deleted the 5066-add-possiblity-to-quickly-include-all-form-fields-in-the-data-to-be-sent-for-the-json-dump-registration-backend branch February 13, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmolen robinmolen robinmolen approved these changes

Assignees
No one assigned
Labels
owner: venlo topic: registration
Projects
None yet
Milestone
No milestone
2 participants
@viktorvanwijk @robinmolen