Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5090] Make softRequiredErrors component always non required #5116

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[#5090] Make softRequiredErrors component always non required #5116

merged 1 commit into from
Feb 26, 2025

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Feb 21, 2025 •
edited
Loading

Closes #5090

Changes

Made softReuiredErrors always non required

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Feb 21, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (a4e2c38) to head (60d086a).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5116   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         774      774           
  Lines       26657    26657           
  Branches     3468     3468           
=======================================
  Hits        25787    25787           
  Misses        608      608           
  Partials      262      262

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergei-maertens

This comment was marked as resolved.

Sign in to view

@sergei-maertens
Copy link
Member

I'll merge and backport this now

@sergei-maertens sergei-maertens merged commit 1086647 into master Feb 26, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the fix/5090-soft-required-component-blocks-next-step branch February 26, 2025 10:21
sergei-maertens pushed a commit that referenced this pull request Feb 26, 2025
@vaszig @sergei-maertens
[#5090] Made softRequiredErrors component always non required
2df9ce1 
Backport-of: #5116
@sergei-maertens
Copy link
Member

Backported to 3.0.x in 2df9ce1 - older versions didn't have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Soft requirement of uploads block next step
2 participants
@vaszig @sergei-maertens