Wrapping array data fields in variable table #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5097 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 771 771
Lines 26636 26636
Branches 3467 3467
=======================================
Hits 25770 25770
Misses 605 605
Partials 261 261 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Feb 11, 2025
| @@ -146,6 +151,7 @@ Field.propTypes = { | |||
| ]), | |||
| fieldBox: PropTypes.bool, | |||
| disabled: PropTypes.bool, | |||
| extraModifiers: PropTypes.arrayOf(PropTypes.oneOf(['flex-wrap'])), | |||
There was a problem hiding this comment.
Should this be this specific array?I mean, if we want to add something in the future we will have to update this as well, right?
There was a problem hiding this comment.
I think this is what we want. This ensures that we only allow this specific modifier to be used.
And indeed if we want to support more modifiers in the future, we will have to update this array. But it ensures that only expected values are used.
robinmolen
deleted the
feature/5093-literal-value-input-for-array-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5093
Changes
Displaying the array fields below the
Use raw JSON inputcheckbox in the form variable table.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene