fix domain rbac playwright failure

open-metadata · Feb 23, 2025 · 29a3d13 · 29a3d13
1 parent e1e3ec6
commit 29a3d13
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts
@@ -516,20 +516,17 @@ test.describe('Domains Rbac', () => {
 
     // Add domain role to the user
     await visitUserProfilePage(page, user1.responseData.name);
-    await page
-      .getByTestId('user-profile')
-      .locator('.ant-collapse-expand-icon')
-      .click();
     await page.getByTestId('edit-roles-button').click();
 
-    await page
-      .getByTestId('select-user-roles')
-      .getByLabel('Select roles')
-      .click();
+    await page.locator('[data-testid="user-profile-edit-popover"]').isVisible();
+    await page.locator('input[role="combobox"]').nth(1).click();
+    await page.waitForSelector('[data-testid="profile-edit-roles-select"]');
     await page.getByText('Domain Only Access Role').click();
     await page.click('body');
     const patchRes = page.waitForResponse('/api/v1/users/*');
-    await page.getByTestId('inline-save-btn').click();
+    await page
+      .locator('[data-testid="user-profile-edit-roles-save-button"]')
+      .click();
     await patchRes;
     await afterAction();
   });

diff --git a/...rc/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx b/...rc/components/Settings/Users/UsersProfile/UserProfileRoles/UserProfileRoles.component.tsx
@@ -227,7 +227,7 @@ const UserProfileRoles = ({
                     showSearch
                     aria-label="Roles"
                     className="w-full"
-                    data-testid="persona-edit-roles"
+                    data-testid="profile-edit-roles-select"
                     dropdownMatchSelectWidth={false}
                     filterOption={handleSearchFilterOption}
                     loading={isLoading}