Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Revamp user profile Page #19566

Merged
merged 104 commits into from
Feb 24, 2025

Conversation

shrushti2000
Copy link
Contributor

@shrushti2000 shrushti2000 commented Jan 28, 2025

Fixes: #15689

User Profile Page Revamp.

Figma

Manage Profile (Edit display name, change password and delete profile)
https://github.com/user-attachments/assets/e26519c2-5f4a-49cf-a420-5a6856465c3b

Persona, Teams ,Domain and Roles
https://github.com/user-attachments/assets/bcae515f-d63b-4733-a7e5-3dbb2e31906e

Activity Feed Tab
https://github.com/user-attachments/assets/f320b03f-8e66-44f6-a22c-bf160e603b09

Task Tab
https://github.com/user-attachments/assets/26a7918a-7f4e-4f98-ac6a-aae006bf6d52

Data Assets Tab
https://github.com/user-attachments/assets/207a1c0a-a3ec-4160-b3bf-62f97e3bebaa

Following tab

Screenshot 2025-02-19 at 12 30 42 PM

Access Token
Screenshot 2025-02-19 at 12 40 58 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

chirag-madlani
chirag-madlani previously approved these changes Feb 23, 2025
Comment on lines +56 to +58
const getDefaultValue = (defaultMessage: string) => {
return MarkdownToHTMLConverter.makeHtml(getFrontEndFormat(defaultMessage));
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can move to a util

Comment on lines 117 to 138
const updatePTags = () => {
const pTags = document.querySelectorAll('div.tiptap p');

pTags.forEach((pTag) => {
// Check if <p> tag is empty or contains only a <br class="ProseMirror-trailingBreak">
const hasOnlyTrailingBreak =
pTag.children.length === 1 &&
pTag.children[0].tagName === 'BR' &&
pTag.children[0].classList.contains('ProseMirror-trailingBreak');

if (pTag.textContent?.trim() === '' || hasOnlyTrailingBreak) {
pTag.remove();
}
});
};

// Call the updatePTags function whenever editor content changes
useEffect(() => {
if (editor) {
updatePTags();
}
}, [editor?.getHTML()]); // Trigger whenever editor's HTML content is updated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will remove all the empty

tag even when user has added intentionally?

Copy link

@chirag-madlani chirag-madlani merged commit 907d3a9 into open-metadata:main Feb 24, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revamp persona selection list for default persona
4 participants