-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Revamp user profile Page #19566
Feat: Revamp user profile Page #19566
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
const getDefaultValue = (defaultMessage: string) => { | ||
return MarkdownToHTMLConverter.makeHtml(getFrontEndFormat(defaultMessage)); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can move to a util
const updatePTags = () => { | ||
const pTags = document.querySelectorAll('div.tiptap p'); | ||
|
||
pTags.forEach((pTag) => { | ||
// Check if <p> tag is empty or contains only a <br class="ProseMirror-trailingBreak"> | ||
const hasOnlyTrailingBreak = | ||
pTag.children.length === 1 && | ||
pTag.children[0].tagName === 'BR' && | ||
pTag.children[0].classList.contains('ProseMirror-trailingBreak'); | ||
|
||
if (pTag.textContent?.trim() === '' || hasOnlyTrailingBreak) { | ||
pTag.remove(); | ||
} | ||
}); | ||
}; | ||
|
||
// Call the updatePTags function whenever editor content changes | ||
useEffect(() => { | ||
if (editor) { | ||
updatePTags(); | ||
} | ||
}, [editor?.getHTML()]); // Trigger whenever editor's HTML content is updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will remove all the empty
tag even when user has added intentionally?
|
Fixes: #15689
User Profile Page Revamp.
Figma
Manage Profile (Edit display name, change password and delete profile)
https://github.com/user-attachments/assets/e26519c2-5f4a-49cf-a420-5a6856465c3b
Persona, Teams ,Domain and Roles
https://github.com/user-attachments/assets/bcae515f-d63b-4733-a7e5-3dbb2e31906e
Activity Feed Tab
https://github.com/user-attachments/assets/f320b03f-8e66-44f6-a22c-bf160e603b09
Task Tab
https://github.com/user-attachments/assets/26a7918a-7f4e-4f98-ac6a-aae006bf6d52
Data Assets Tab
https://github.com/user-attachments/assets/207a1c0a-a3ec-4160-b3bf-62f97e3bebaa
Following tab
Access Token

Type of change:
Checklist:
Fixes <issue-number>: <short explanation>