Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17742 - show sub domain assets to top level #19679

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Fix #17742 - show sub domain assets to top level #19679

merged 11 commits into from
Feb 11, 2025

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Feb 5, 2025 •
edited
Loading

Describe your changes:

Fixes #17742
Fixes #19573

Screen.Recording.2025-02-07.at.7.35.48.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 requested a review from a team as a code owner February 5, 2025 12:02
@karanh37 karanh37 marked this pull request as draft February 5, 2025 12:02
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Feb 5, 2025
@karanh37 karanh37 changed the title show sub domain assets to top level Fix #17742 - show sub domain assets to top level Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.63% (41361/63997) 40.99% (16703/40749) 44.2% (5038/11397)

@karanh37 karanh37 marked this pull request as ready for review February 7, 2025 14:04
@karanh37 karanh37 added the To release Will cherry-pick this PR into the release branch label Feb 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@karanh37 karanh37 merged commit fba92df into main Feb 11, 2025
15 of 17 checks passed
@karanh37 karanh37 deleted the issue-17742 branch February 11, 2025 09:21
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.4 branch.
Please cherry-pick the changes manually.
You can find more details here.

karanh37 added a commit that referenced this pull request Feb 11, 2025
@karanh37
Fix #17742 - show sub domain assets to top level (#19679)
ae5bc69 
* show sub domain assets to top level

* add domain selection tree in navbar

* fix domain playwright

* fix tree selectable

* fix domain tests

* fix domain cancel action

* fix sonar issues

* add tests

(cherry picked from commit fba92df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
3 participants
@karanh37 @chirag-madlani @aniketkatkar97