Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update data model header asset #19729

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix: Update data model header asset #19729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfeff93
update data model header asset to include project
sweta1308 Feb 10, 2025
d73a5cd
add playwright test for project
sweta1308 Feb 11, 2025
7047492
Merge branch 'main' into fix-data-model-project
sweta1308 Feb 11, 2025
32d3cf8
update entity test
sweta1308 Feb 11, 2025
142c0ef
update condition for test
sweta1308 Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { test } from '@playwright/test';
import { expect, test } from '@playwright/test';
import { isUndefined } from 'lodash';
import { CustomPropertySupportedEntityList } from '../../constant/customProperty';
import { ApiEndpointClass } from '../../support/entity/ApiEndpointClass';
Expand Down Expand Up @@ -65,8 +65,9 @@ test.use({ storageState: 'playwright/.auth/admin.json' });
entities.forEach((EntityClass) => {
const entity = new EntityClass();
const deleteEntity = new EntityClass();
const entityName = entity.getType();

test.describe(entity.getType(), () => {
test.describe(entityName, () => {
test.beforeAll('Setup pre-requests', async ({ browser }) => {
const { apiContext, afterAction } = await createNewPage(browser);

Expand Down Expand Up @@ -192,6 +193,16 @@ entities.forEach((EntityClass) => {
);
});

if (['Dashboard', 'Dashboard Data Model'].includes(entityName)) {
test(`${entityName} page should show the project name`, async ({
page,
}) => {
await expect(
page.getByText((entity.entity as { project: string }).project)
).toBeVisible();
});
}

test('Update description', async ({ page }) => {
await entity.descriptionUpdate(page);
});
Expand Down
2 changes: 2 additions & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/support/entity/DashboardClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { EntityClass } from './EntityClass';
export class DashboardClass extends EntityClass {
private dashboardName = `pw-dashboard-${uuid()}`;
private dashboardDataModelName = `pw-dashboard-data-model-${uuid()}`;
private projectName = `pw-project-${uuid()}`;
service = {
name: `pw-dashboard-service-${uuid()}`,
serviceType: 'Superset',
Expand All @@ -51,6 +52,7 @@ export class DashboardClass extends EntityClass {
name: this.dashboardName,
displayName: this.dashboardName,
service: this.service.name,
project: this.projectName,
};
children = [
{
Expand Down
6 changes: 6 additions & 0 deletions openmetadata-ui/src/main/resources/ui/src/utils/DataAssetsHeader.utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,12 @@ export const getDataAssetsHeaderInfo = (
value={dataModelDetails.dataModelType}
/>
)}
{dataModelDetails.project && (
<ExtraInfoLabel
label={t('label.project')}
value={dataModelDetails.project}
/>
)}
</>
);

Expand Down
Loading