From 5c11b10346d0341dad8d0fea037f93678307751f Mon Sep 17 00:00:00 2001 From: Karan Hotchandani <33024356+karanh37@users.noreply.github.com> Date: Mon, 17 Feb 2025 16:36:02 +0530 Subject: [PATCH] Revert "Fix: close select dropdown when focus is shifted (#19764)" This reverts commit 7b495072e094d71c9248225723ff5a3abd0479af. --- .../ui/playwright/e2e/Pages/Entity.spec.ts | 9 --------- .../resources/ui/playwright/utils/entity.ts | 18 ------------------ .../common/AsyncSelectList/AsyncSelectList.tsx | 1 - .../AsyncSelectList/TreeAsyncSelectList.tsx | 1 - 4 files changed, 29 deletions(-) diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts index 6ce8a8d11fac..f0aa8825e374 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Entity.spec.ts @@ -40,7 +40,6 @@ import { import { CustomPropertyTypeByName } from '../../utils/customProperty'; import { addMultiOwner, - dropdownVisibility, removeOwner, removeOwnersFromList, } from '../../utils/entity'; @@ -220,14 +219,6 @@ entities.forEach((EntityClass) => { ); }); - test("Tags and Glossary Term dropdown shouldn't be visible on tab change", async ({ - page, - }) => { - await dropdownVisibility(page, 'tags'); - await page.getByRole('tablist').getByRole('tab').first().click(); - await dropdownVisibility(page, 'glossary'); - }); - // Run only if entity has children if (!isUndefined(entity.childrenTabId)) { test('Tag Add, Update and Remove for child entities', async ({ diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts index 514c4ce500be..4d5eb618beb0 100644 --- a/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts +++ b/openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts @@ -709,24 +709,6 @@ export const removeGlossaryTermFromChildren = async ({ } }; -export const dropdownVisibility = async (page: Page, tagType: string) => { - await page - .getByTestId('entity-right-panel') - .getByTestId(`${tagType}-container`) - .getByTestId('add-tag') - .click(); - await page.waitForSelector( - '.ant-select-dropdown [data-testid="saveAssociatedTag"]', - { state: 'visible' } - ); - - await expect(page.getByTestId('saveAssociatedTag')).toBeVisible(); - - await page.getByTestId('activity_feed').click(); - - await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible(); -}; - export const upVote = async (page: Page, endPoint: string) => { const patchRequest = page.waitForResponse(`/api/v1/${endPoint}/*/vote`); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/AsyncSelectList.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/AsyncSelectList.tsx index 61bb5bc7b3c3..3bd1621e228d 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/AsyncSelectList.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/AsyncSelectList.tsx @@ -315,7 +315,6 @@ const AsyncSelectList: FC = ({ style={{ width: '100%' }} tagRender={customTagRender} onChange={handleChange} - onDropdownVisibleChange={(open) => !open && onCancel?.()} onInputKeyDown={(event) => { if (event.key === 'Backspace') { return event.stopPropagation(); diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx index 40c3e75b2504..ccd96f06df98 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx @@ -328,7 +328,6 @@ const TreeAsyncSelectList: FC> = ({ treeData={treeData} treeExpandedKeys={isEmpty(searchOptions) ? undefined : expandedRowKeys} onChange={handleChange} - onDropdownVisibleChange={(open) => !open && onCancel?.()} onSearch={onSearch} onTreeExpand={setExpandedRowKeys} {...props}