Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix the tour page getting close in explore page #19874

Merged
merged 1 commit into from
Feb 19, 2025
Merged

MINOR: fix the tour page getting close in explore page #19874

merged 1 commit into from
Feb 19, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 19, 2025 •
edited
Loading

Describe your changes:

Issue :

  • Tour page getting close on the explore page, due to delay in page response and can't find the next selector on the page.
  • Fix User.spec flaky playwright test.

Fixed:

  • Increase the waiting time on page to 900ms.

Issue :

Screen.Recording.2025-02-19.at.1.40.39.PM.mov

Fixed :

Screen.Recording.2025-02-19.at.1.41.24.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Feb 19, 2025
@Ashish8689 Ashish8689 self-assigned this Feb 19, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner February 19, 2025 08:16
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (41383/64009) 41.04% (16732/40766) 44.24% (5042/11398)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit fe300b7 into main Feb 19, 2025
27 of 30 checks passed
@chirag-madlani chirag-madlani deleted the tour-fix branch February 19, 2025 09:18
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.4 branch.

github-actions bot pushed a commit that referenced this pull request Feb 19, 2025
@Ashish8689
fix the tour page getting close in explore page (#19874)
1e0182e 
(cherry picked from commit fe300b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 left review comments

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashish8689 @aniketkatkar97 @ShaileshParmar11 @chirag-madlani