Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: type errors on main #19916

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix: type errors on main #19916

merged 2 commits into from
Feb 21, 2025

Conversation

aniketkatkar97
Copy link
Member

I worked on adding the missing types generated from JSON schemas

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Feb 21, 2025
@aniketkatkar97 aniketkatkar97 self-assigned this Feb 21, 2025
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner February 21, 2025 11:10
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (41398/64035) 41.04% (16734/40779) 44.22% (5042/11402)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit b7cb311 into main Feb 21, 2025
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the add-missing-types branch February 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketkatkar97 @chirag-madlani