Skip to content

Commit 23f4a57

Browse files
Minor: Connector details header fix (#246)
* add alation connector image * add margin to connectorsListContainer * fix feature list heading showing in case no feature is present
1 parent a4604c1 commit 23f4a57

File tree

3 files changed

+42
-26
lines changed

3 files changed

+42
-26
lines changed

components/ConnectorDetailsHeader/ConnectorDetailsHeader.tsx

Lines changed: 37 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import classNames from "classnames";
2+
import { isEmpty } from "lodash";
3+
import { useMemo } from "react";
24
import { ReactComponent as CheckIcon } from "../../images/icons/check.svg";
35
import { ReactComponent as CrossIcon } from "../../images/icons/cross.svg";
46
import {
@@ -16,6 +18,11 @@ function ConnectorDetailsHeader({
1618
availableFeatures,
1719
unavailableFeatures,
1820
}: Readonly<ConnectorDetailsHeaderProps>) {
21+
const showSubHeading = useMemo(
22+
() => !isEmpty(availableFeatures) || !isEmpty(unavailableFeatures),
23+
[availableFeatures, unavailableFeatures]
24+
);
25+
1926
return (
2027
<div className={styles.Container}>
2128
<div className={styles.Heading}>
@@ -31,32 +38,37 @@ function ConnectorDetailsHeader({
3138
</div>
3239
</div>
3340
</div>
34-
<div className={styles.SubHeading}>
35-
<div className={styles.FeaturesHeading}>Feature List</div>
36-
<div className={styles.FeaturesList}>
37-
{availableFeatures.map((feature) => (
38-
<div
39-
className={classNames(styles.FeatureTag, styles.AvailableFeature)}
40-
key={feature}
41-
>
42-
{feature}
43-
<CheckIcon height={12} />
44-
</div>
45-
))}
46-
{unavailableFeatures.map((feature) => (
47-
<div
48-
className={classNames(
49-
styles.FeatureTag,
50-
styles.UnavailableFeature
51-
)}
52-
key={feature}
53-
>
54-
{feature}
55-
<CrossIcon height={14} />
56-
</div>
57-
))}
41+
{showSubHeading && (
42+
<div className={styles.SubHeading}>
43+
<div className={styles.FeaturesHeading}>Feature List</div>
44+
<div className={styles.FeaturesList}>
45+
{availableFeatures.map((feature) => (
46+
<div
47+
className={classNames(
48+
styles.FeatureTag,
49+
styles.AvailableFeature
50+
)}
51+
key={feature}
52+
>
53+
{feature}
54+
<CheckIcon height={12} />
55+
</div>
56+
))}
57+
{unavailableFeatures.map((feature) => (
58+
<div
59+
className={classNames(
60+
styles.FeatureTag,
61+
styles.UnavailableFeature
62+
)}
63+
key={feature}
64+
>
65+
{feature}
66+
<CrossIcon height={14} />
67+
</div>
68+
))}
69+
</div>
5870
</div>
59-
</div>
71+
)}
6072
</div>
6173
);
6274
}

components/ConnectorsListContainer/ConnectorsListContainer.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.Container{
2-
margin-top: 24px;
2+
margin: 24px 0px;
33
display: grid;
44
gap: 24px
55
}

utils/ConnectorsUtils.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ export const getConnectorImage = (connector: string) => {
7272
iconSource = "athena";
7373
break;
7474

75+
case "Alation":
76+
iconSource = "alation";
77+
break;
78+
7579
case "S3":
7680
case "Datalake":
7781
iconSource = "amazon-s3";

0 commit comments

Comments
 (0)