Skip to content

Commit 121a990

Browse files
renovate[bot]trask
andauthored
Update opentelemetry packages (#421)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]>
1 parent 8426d2e commit 121a990

File tree

5 files changed

+28
-20
lines changed

5 files changed

+28
-20
lines changed

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ subprojects {
1818

1919
dependencies {
2020
// using the bom ensures that all of your opentelemetry dependency versions are aligned
21-
implementation(platform("io.opentelemetry:opentelemetry-bom-alpha:1.38.0-alpha"))
21+
implementation(platform("io.opentelemetry:opentelemetry-bom-alpha:1.39.0-alpha"))
2222
implementation(platform("io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.4.0-alpha"))
2323
}
2424

http/src/main/java/io/opentelemetry/example/http/HttpClient.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
import io.opentelemetry.api.trace.StatusCode;
1313
import io.opentelemetry.api.trace.Tracer;
1414
import io.opentelemetry.context.Scope;
15-
import io.opentelemetry.semconv.SemanticAttributes;
15+
import io.opentelemetry.semconv.HttpAttributes;
16+
import io.opentelemetry.semconv.UrlAttributes;
1617
import java.io.BufferedReader;
1718
import java.io.IOException;
1819
import java.io.InputStreamReader;
@@ -43,7 +44,7 @@ private void makeRequest() throws IOException, URISyntaxException {
4344
// See: https://github.com/open-telemetry/opentelemetry-specification/issues/270
4445
Span span = tracer.spanBuilder("/").setSpanKind(SpanKind.CLIENT).startSpan();
4546
try (Scope scope = span.makeCurrent()) {
46-
span.setAttribute(SemanticAttributes.HTTP_REQUEST_METHOD, "GET");
47+
span.setAttribute(HttpAttributes.HTTP_REQUEST_METHOD, "GET");
4748
span.setAttribute("component", "http");
4849
/*
4950
Only one of the following is required
@@ -64,7 +65,7 @@ private void makeRequest() throws IOException, URISyntaxException {
6465
uri.getFragment())
6566
.toURL();
6667

67-
span.setAttribute(SemanticAttributes.URL_FULL, url.toString());
68+
span.setAttribute(UrlAttributes.URL_FULL, url.toString());
6869

6970
// Inject the request with the current Context/Span.
7071
ExtendedContextPropagators.getTextMapPropagationContext(openTelemetry.getPropagators())

http/src/main/java/io/opentelemetry/example/http/HttpServer.java

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
import com.sun.net.httpserver.HttpHandler;
1212
import io.opentelemetry.api.OpenTelemetry;
1313
import io.opentelemetry.api.common.Attributes;
14-
import io.opentelemetry.api.incubator.trace.ExtendedTracer;
14+
import io.opentelemetry.api.incubator.trace.ExtendedSpanBuilder;
1515
import io.opentelemetry.api.trace.Span;
1616
import io.opentelemetry.api.trace.SpanKind;
17+
import io.opentelemetry.api.trace.Tracer;
1718
import java.io.IOException;
1819
import java.io.OutputStream;
1920
import java.net.InetSocketAddress;
@@ -25,8 +26,8 @@ public final class HttpServer {
2526
// It's important to initialize your OpenTelemetry SDK as early in your application's lifecycle as
2627
// possible.
2728
private static final OpenTelemetry openTelemetry = ExampleConfiguration.initOpenTelemetry();
28-
private static final ExtendedTracer tracer =
29-
ExtendedTracer.create(openTelemetry.getTracer("io.opentelemetry.example.http.HttpServer"));
29+
private static final Tracer tracer =
30+
openTelemetry.getTracer("io.opentelemetry.example.http.HttpServer");
3031

3132
private static final int port = 8080;
3233
private final com.sun.net.httpserver.HttpServer server;
@@ -47,13 +48,15 @@ private static class HelloHandler implements HttpHandler {
4748

4849
@Override
4950
public void handle(HttpExchange exchange) throws IOException {
50-
tracer
51-
.spanBuilder("GET /")
52-
.setParentFrom(
53-
openTelemetry.getPropagators(),
54-
exchange.getRequestHeaders().entrySet().stream()
55-
.collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0))))
56-
.setSpanKind(SpanKind.SERVER)
51+
// TODO (trask) clean up chaining after
52+
// https://github.com/open-telemetry/opentelemetry-java/pull/6514
53+
((ExtendedSpanBuilder)
54+
((ExtendedSpanBuilder) tracer.spanBuilder("GET /"))
55+
.setParentFrom(
56+
openTelemetry.getPropagators(),
57+
exchange.getRequestHeaders().entrySet().stream()
58+
.collect(Collectors.toMap(Map.Entry::getKey, e -> e.getValue().get(0))))
59+
.setSpanKind(SpanKind.SERVER))
5760
.startAndRun(
5861
() -> {
5962
// Set the Semantic Convention

manual-tracing/src/main/java/io/opentelemetry/example/tracing/ManualTracingExample.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
import io.opentelemetry.api.OpenTelemetry;
44
import io.opentelemetry.api.baggage.Baggage;
5-
import io.opentelemetry.api.incubator.trace.ExtendedTracer;
5+
import io.opentelemetry.api.incubator.trace.ExtendedSpanBuilder;
66
import io.opentelemetry.api.trace.Span;
7+
import io.opentelemetry.api.trace.Tracer;
78
import io.opentelemetry.context.Context;
89

910
/**
@@ -13,14 +14,14 @@
1314
public final class ManualTracingExample {
1415
private static final String INSTRUMENTATION_NAME = ManualTracingExample.class.getName();
1516

16-
private final ExtendedTracer tracer;
17+
private final Tracer tracer;
1718

1819
public ManualTracingExample(OpenTelemetry openTelemetry) {
19-
tracer = ExtendedTracer.create(openTelemetry.getTracer(INSTRUMENTATION_NAME));
20+
tracer = openTelemetry.getTracer(INSTRUMENTATION_NAME);
2021
}
2122

2223
public void myWonderfulUseCase() {
23-
tracer.spanBuilder("calculate LLVM").startAndCall(this::calculateLlvm);
24+
((ExtendedSpanBuilder) tracer.spanBuilder("calculate LLVM")).startAndCall(this::calculateLlvm);
2425
}
2526

2627
private String calculateLlvm() {
@@ -36,7 +37,10 @@ public void setBaggageAndRun() {
3637
.put("foo", "bar")
3738
.build()
3839
.storeInContext(Context.current())
39-
.wrap(() -> tracer.spanBuilder("span with baggage").startAndCall(this::calculateLlvm))
40+
.wrap(
41+
() ->
42+
((ExtendedSpanBuilder) tracer.spanBuilder("span with baggage"))
43+
.startAndCall(this::calculateLlvm))
4044
.call();
4145
} catch (Exception e) {
4246
throw new RuntimeException(e);

spring-native/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ val moduleName by extra { "io.opentelemetry.examples.native" }
1111

1212
dependencies {
1313
implementation(platform(SpringBootPlugin.BOM_COORDINATES))
14-
implementation(platform("io.opentelemetry:opentelemetry-bom:1.38.0"))
14+
implementation(platform("io.opentelemetry:opentelemetry-bom:1.39.0"))
1515
implementation(platform("io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:2.4.0-alpha"))
1616
implementation("org.springframework.boot:spring-boot-starter-actuator")
1717
implementation("org.springframework.boot:spring-boot-starter-web")

0 commit comments

Comments
 (0)