Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More runtime metrics for Spring starter with GraalVM #13245

Open
zeitlinger opened this issue Feb 7, 2025 · 1 comment
Open

More runtime metrics for Spring starter with GraalVM #13245

zeitlinger opened this issue Feb 7, 2025 · 1 comment
Labels
enhancement New feature or request needs triage New issue that requires triage

Comments

@zeitlinger
Copy link
Member

zeitlinger commented Feb 7, 2025

Feature

Spring starter with GraalVM currently (when #13173 is merged) doesn't support

GraalVM 23

PR: #13269

Once JFR metrics work: the current setup only tests the latest LTS version of GraalVM.

Graal 23 has a different options for enabling JFR - which has been tried out in #13078 - this line: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/13078/files#diff-75989ca3659128c1bc6aea21d1129a7a704b98959fad35345d5c3c216c53c91cR71

It may turn out that JFR metrics are only possible with Graal 23, which would mean that we have test 23.
If 21 also supports JFR metrics, we still want to test 23 - to know that our JFR metrics will not break in the
future.

Cleanup

Runtime metrics are currently configured in RuntimeMetricsAutoConfiguration class.

#13236 is a PR with a cleaner separation
of runtime metrics into different @Configuration classes.
It turned out that the RuntimeMetricsBeanRegistrationExcludeFilter can't exclude @Configuration classes, so
we discarded that approach. => solved by excluding the bean contained un the autoconfiguration

@zeitlinger zeitlinger added enhancement New feature or request needs triage New issue that requires triage labels Feb 7, 2025
@jeanbisutti
Copy link
Member

An implementation based on autoconfigurations may be less verbose and readable but technically more complicated: #13236 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New issue that requires triage
Projects
None yet
Development

No branches or pull requests

2 participants